Re: [Ipmitool-devel] Error in lanplus.c

[Albert C. <ch...@ll...>]

In addition to that, why is there a sleep(1) in there?  That seems
really bad.  Perhaps some debug code someone left in there by accident?

Al

On Sat, 2011-03-26 at 09:39 -0700, Dick.Detweiler@Emerson.com wrote:
> Hi all,
> 
> I was going through the lanplus code ensuring I didn't mess things up with some changes I was making and ran across this at line 3552 of lanplus.c in version 1.8.10:
> 
> 3550:        if (ipmi_get_auth_capabilities_cmd(intf, &auth_cap)) {
> 3551:                sleep(1);
> 3552:                if (ipmi_get_auth_capabilities_cmd(intf, &auth_cap));
> 3553:                {
> 3554:                        lprintf(LOG_INFO, "Error issuing Get Channel "
> 3555:                                "Authentication Capabilies request");
> 3556:                        goto fail;
> 3557:                }
> 3558:        }
> 
> The old semi-colon at the end of the if() clause!  So this code goes to fail every time and not just when ipmi_get_auth_capabilities_cmd returns 1.
> 
> FYI,
> Dick
> 
> ------------------------------------------------------------------------------
> Enable your software for Intel(R) Active Management Technology to meet the
> growing manageability and security demands of your customers. Businesses
> are taking advantage of Intel(R) vPro (TM) technology - will your software 
> be a part of the solution? Download the Intel(R) Manageability Checker 
> today! http://p.sf.net/sfu/intel-dev2devmar
> _______________________________________________
> Ipmitool-devel mailing list
> Ipm...@li...
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
-- 
Albert Chu
ch...@ll...
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory