[Ipfilter-bugs] [ ipfilter-Bugs-1988927 ] ip_fil_solaris.c doesn't compile (head branch)

[SourceForge.net <no...@so...>]

Bugs item #1988927, was opened at 2008-06-09 07:10
Message generated for change (Comment added) made by darren_r
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=849053&aid=1988927&group_id=169098

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: building
Group: 5.0.*
>Status: Pending
>Resolution: Fixed
Priority: 6
Private: No
Submitted By: JohnO (john_oj)
>Assigned to: Darren (darren_r)
Summary: ip_fil_solaris.c doesn't compile (head branch)

Initial Comment:
There are several problems with ip_fil_solaris.c file when
trying to build on Solaris system:

gcc -I../.. -DIPFILTER_LKM -I../../../pfil -D_KERNEL -DSUNDDI  -DSOLARIS2=10 -DIPFILTER_LOG -DIPFILTER_LOOKUP   -c ../../ip_fil_solaris.c -o sparcv7/ip_fil.o
../../ip_fil_solaris.c: In function `ipf_send_reset':
../../ip_fil_solaris.c:338: error: incompatible types in assignment
../../ip_fil_solaris.c:339: error: incompatible types in assignment
../../ip_fil_solaris.c:353: warning: passing arg 1 of `ipf_cksum' from incompatible pointer type
../../ip_fil_solaris.c:353: warning: passing arg 2 of `ipf_cksum' makes integer from pointer without a cast
../../ip_fil_solaris.c:353: error: too many arguments to function `ipf_cksum'
../../ip_fil_solaris.c: In function `ipf_send_icmp_err':
../../ip_fil_solaris.c:533: error: incompatible types in assignment
../../ip_fil_solaris.c:534: error: incompatible types in assignment
../../ip_fil_solaris.c: In function `ipf_fastroute':
../../ip_fil_solaris.c:929: error: incompatible types in assignment
../../ip_fil_solaris.c:991:1: unterminated #ifndef
../../ip_fil_solaris.c:989: error: syntax error at end of input
../../ip_fil_solaris.c:904: error: label `bad_fastroute' used but not defined
*** Error code 1

Not sure about the assignment problems, but the #ifndef issue tells me that building
this on Solaris box has not been attempted until now; as there's no way this can
compile as is.  Some code was removed after #ifndef (including #endif), but was never
completed ... there is no #endif to close things.



----------------------------------------------------------------------

>Comment By: Darren (darren_r)
Date: 2008-07-17 02:46

Message:
Logged In: YES 
user_id=1448875
Originator: NO

THis should now be fixed.

I've marked this as "Pending" - please reply if it is still a problem.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=849053&aid=1988927&group_id=169098