Re: [Iodbc-bugs] [PATCH] Fixes for the pkg-config file and iodbc-config

[Daniel R. G. <os...@te...>]

On Sat, 25 Aug 2012, Brad Smith wrote:

> The diff below fixes the pkg-config file by substituting -ldl for 
> LIBADD_DL since some OS's do not have a libdl and adds the missing 
> libpthread for Libs.private to fix the static linking. For iodbc-config 
> the missing libpthread is added for the static linking scenario.

I agree with substituting @LIBADD_DL@ for -ldl in libiodbc.pc.in; that was 
clearly an oversight.

However, "-lpthread" doesn't necessarily belong in these two files. For 
one, the library could be named -lpthreads (plural), or the pthreads 
functions may already be in the C library (so no additional library is 
needed). For two, iODBC can be built without threading support using 
--disable-pthreads.

Have a look at the "Checkout pthread situation" section in configure.ac. 
-lpthread may be needed in some static-linking scenarios, but that's not 
the only permutation that needs to be covered.


--Daniel


-- 
Daniel Richard G. || da...@te... || Software Developer
Teragram Linguistic Technologies (a division of SAS)
http://www.teragram.com/