[Ilisp-devel] Re: [Ilisp-help] bugfix for default-directory-lisp with cmucl

[Hannu K. <az...@ik...>]

sm...@wa... (Tijs van Bakel) writes:

[I'm sending a copy of this reply to you since I don't know if you
are on the list or not.  Consider using Mail-copies-to and/or
Mail-followup-to headers if you are.  Followups set to
ilisp-devel.]

| I hope this diff fixes the "C-c !" behaviour in CMUCL.  Before,
| directory changing was not possible with the CMUCL dialect.

Few comments.  First, default directory changing was possible with
the CMUCL dialect the way it can be done in any standard Common
Lisp implementation (see ilisp-cl.el).  It's just that this way is,
um, well, not what all people expect.  I any case, I agree that the
modification you suggest is a reasonable thing to do.  Your patch,
however, resulted to wrong indentation being used and it was also
rather awkward to read and apply since it wasn't in unified diff
format.  Please always use unified diff format, which you can
select with the -u option (the default number of lines, 3, is fine)
in GNU diff; it's usually what developers of other free software
packages want, too.  ***Notice that since I'm not an ILISP
developer this doesn't represent their position on this issue.***

Here's an improved patch that also gets rid of the useless comments
and empty lines in ilisp-cmu.el

To ILISP developers:

Note that I also removed an ilisp-error-regexp attribution to Larry
Hunter.  Now that ILISP is using CVS and ChangeLog's indicate from
who the patch came from or who suggested the change (in my patch's
case both at the same time :) ) such comments are futile (IMO).
However, that suggestion has been made before the ChangeLog was
introduced so removing this kind of cases is a bit more
questionable because it leaves no attribution to the current files.
The comment is still in the CVS and I think that would be just fine
for me if I had written the patch / contributed the suggestion, but
perhaps that is not enough as a general way (Larry Hunter or some
other contributor might not think the way I do; besides,
assembling/updating the list of contributors, for example, would be
somewhat easier if one needs to consider only current files and not
old versions from the CVS).  So, as a solution I'd suggest that, if
you think it is enough anyway, use this ChangeLog entry for my
patch (assuming that you think it's ok otherwise and are going to
apply it)...

2001-02-14  Hannu Koivisto  <az...@ik...>

	* ilisp-cmu.el (cmulisp):
	  * Added a CMUCL-specific way to set and get the default directory
	    based on a suggestion by Tijs van Bakel <sm...@wa...>.
	  * Removed excess comments and empty lines.

...and if not, use this one, which applies a trick that leaves the
attribution to the current files in a similar way new contributions
can be seen in the ChangeLog (it's just that in this case we are
documenting an empty change :) )

2001-02-14  Hannu Koivisto  <az...@ik...>

	* ilisp-cmu.el (cmulisp):
	  * Added a CMUCL-specific way to set and get the default directory
	    based on a suggestion by Tijs van Bakel <sm...@wa...>.
	=A0 * ilisp-error-regexp suggested by
	    Larry Hunter <hu...@wo...> retained.
	  * Removed excess comments and empty lines.

--=20
Hannu
Please don't send copies of list mail