#115 win install: no overide of user* plus little improves

closed-accepted
nobody
5
2010-02-12
2009-11-09
daemonui
No

this patch includes.
- eliminates double processing of trust.txt to old_trust.txt
- user.action user.filter are not overwritten anymore
- Altered message on finish if updated
- exec after finish-dialog (get the user a chance to update the config)
- when closing a running Privoxy, wait until it is really gone (max. 20*200 msec)
- adding install / uninstall icon files in winsetup!! (note: uncomment Icon/UninstallIcon in .nsi if undesired)
replacing current/icons/privoxy.ico by winsetup/privoxy.ico makes alt+tab icon a bit more smooth.

https://sourceforge.net/tracker/?func=detail&atid=361118&aid=2727419&group_id=11118

Discussion

  • daemonui
    daemonui
    2009-11-10

    alternative, which includes bug#2888566

     
    Attachments
  • daemonui
    daemonui
    2009-11-10

    readding older patch, somehow deleted

     
    Attachments
  • Fabian Keil
    Fabian Keil
    2010-01-27

    Thanks a lot for the patch.

    Lee, could you please comment on what the status of this is? Is everything of this already committed, or only parts of it?

     
  • Lee
    Lee
    2010-01-28

    • status: open --> pending-accepted
     
  • Lee
    Lee
    2010-01-28

    > Lee, could you please comment on what the status of this is? Is everything
    > of this already committed, or only parts of it?

    Everything is committed with two minor changes.

    It's a little bit embarrassing to admit how long it took me to realize why the patched installer was creating CVS directories; I always grab the source tarball when creating a new release and that doesn't have any CVS directories in it. Duh.. But that's the reason for adding the "/x CVS" to the
    File /r /x CVS /x user.action /x user.filter build\*.*
    line.

    OTOH, I stumbled across a trick for generating unique labels inside a macro while trying to figure out why I was getting CVS directories created with the patched installer. So it wasn't a complete waste of time - I think it's easier to understand jumping to a label than jumping to a relative line number. So that's the other minor change - adding the
    !define UniqueID ${__LINE__}
    line to the macros so they can jump to a label instead of a relative line number.

    Regards,
    Lee

     
    • status: pending-accepted --> closed-accepted
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).