[ icewm-Patches-1394863 ] taskbar workspace buttons with window preview
Brought to you by:
captnmark
From: SourceForge.net <no...@so...> - 2007-03-03 19:56:16
|
Patches item #1394863, was opened at 2006-01-01 17:41 Message generated for change (Comment added) made by speleo3 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300031&aid=1394863&group_id=31 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: another bloating feature Group: None Status: Open Resolution: None Priority: 4 Private: No Submitted By: Thomas Holder (speleo3) Assigned to: Marko Macek (captnmark) Summary: taskbar workspace buttons with window preview Initial Comment: Lets the taskbar workspace buttons appear more like the pager known from other window managers. Shows window preview and handles right click, middle click and mouse wheel. The implementation is far from perfect, there are cases where the preview is not updated correctly, for example when killing unfocused windows. ---------------------------------------------------------------------- >Comment By: Thomas Holder (speleo3) Date: 2007-03-03 20:56 Message: Logged In: YES user_id=1306887 Originator: YES so far the pager always showed minimized windows as unfilled rectangles. Now it's possible to switch that off. Changes in 1.5: * new option: PagerShowMinimized=1 # 0/1 File Added: icewm-1.2.30-aworkspaces-1.5.patch ---------------------------------------------------------------------- Comment By: Owen Marshall (owenjm) Date: 2007-02-26 03:21 Message: Logged In: YES user_id=874762 Originator: NO Just adding a note to say that this is what I've been looking for ever since I started using IceWM - thank you *so* much for implementing this! Works great with 1.2.30 ... Cheers, Owen ---------------------------------------------------------------------- Comment By: Adam Pribyl (covexx) Date: 2006-02-25 17:22 Message: Logged In: YES user_id=607018 Confirming working ok now on both 32 and 64bit platforms.:) Icons as well. ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-02-24 12:46 Message: Logged In: YES user_id=1306887 Changes in 1.4: * replaced itoa with sprintf (thanks to covexx!) * window icons in preview; can be switched off with: PagerShowWindowIcons=0 # 0/1 ---------------------------------------------------------------------- Comment By: Adam Pribyl (covexx) Date: 2006-02-23 10:22 Message: Logged In: YES user_id=607018 Attaching my findings also here: I maybe found something that could cause this sigsegv in icewm pager code. Problem I see in this line const char *label = itoa(fWorkspace+1); 1. itoa function that is used in aworkspaces.cc near line 326 is not an ANSI C function. There should be used sprintf. 2. fWorkspaces is of type long int - this has probably different length on 64bit platform and the conversion itoa puts something wrong in label (it's int to string not long int to string). Therefore strlen crashes on counting length of this number converted to string. ---------------------------------------------------------------------- Comment By: Adam Pribyl (covexx) Date: 2006-02-08 19:34 Message: Logged In: YES user_id=607018 I have to report sigsegv of icewm with this pager enabled and default setup of 1.2.25 on AMD 64 FC4. Program received signal SIGSEGV, Segmentation fault. 0x0000003231c72000 in strlen () from /lib64/libc.so.6 (gdb) bt #0 0x0000003231c72000 in strlen () from /lib64/libc.so.6 #1 0x00000000004753b4 in YFont::textWidth (this=0x691030, str=0x0) at yfont.cc:57 #2 0x00000000004458af in WorkspaceButton::paint (this=Variable "this" is not available. ) at aworkspaces.cc:326 #3 0x0000000000468d82 in YWindow::paintExpose (this=0x683ef0, ex=0, ey=0, ew=Variable "ew" ) at ywindow.cc:703 #4 0x00000000004672c3 in YWindow::handleEvent (this=0x683ef0, event=@0x7fffff8a55f0) at ywindow.cc:596 #5 0x0000000000463ad6 in YXApplication::handleWindowEvent ( this=0x7fffff8a5840, xwindow=Variable "xwindow" is not available. ) at yxapp.cc:894 #6 0x0000000000464000 in YXApplication::handleXEvents (this=0x7fffff8a5840) at yxapp.cc:844 #7 0x00000000004626ea in YApplication::mainLoop (this=0x7fffff8a5840) at yapp.cc:237 #8 0x000000000042b85a in main (argc=1, argv=0x7fffff8a5af8) at wmapp.cc:1527 ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-02-07 13:59 Message: Logged In: YES user_id=1306887 just a quick note: the strange behaviour reported by nobody was related to some weird mixup of his environment. It's all fine now :-) ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-02-05 22:04 Message: Logged In: YES user_id=1306887 @nobody: unfortunately you didn't leave an email address, so it's hard for me to guess what exactly is your problem with xmms, cause it works fine for me. I tested the patch on various Linux systems (gentoo, suse, ... but not debian). Please contact me: speleo3 at users.sourceforge.net ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-02-05 14:13 Message: Logged In: NO Thank you for your work! :-) But unfortunatly the xmms problem is still here (Debian, icewm-1.2.25pre1 + patch 1.0). Furthermore, when I start icewm, I don't see the pager, and see it again only after restarting icewm from the menu (earlier patches didn't cause this problem). The introduced options don't work with my icewm. ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-02-02 21:51 Message: Logged In: YES user_id=1306887 well, finally it has an option to disable the preview :-) I dropped the two already introduced options and replaced them with shorter ones: PagerShowPreview=0 # 0/1 PagerShowBorders=1 # 0/1 PagerShowNumbers=1 # 0/1 Other changes in 1.0: * fixed the xmms issue * fixed killing of unfocused windows ---------------------------------------------------------------------- Comment By: Marko Macek (captnmark) Date: 2006-01-31 20:35 Message: Logged In: YES user_id=1814 I'd be happy to add this to next 1.2 version, if it was added with an option and be disabled by default. ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-01-26 18:18 Message: Logged In: YES user_id=1306887 Changes in 0.6: * Bugfix: Now works correct with --disable-winmenu ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-01-11 20:17 Message: Logged In: YES user_id=1306887 Changes in 0.5: * preview ignores windows that have ignoreWinList:1 * calculations are done with float precision, so preview of small windows is improved ---------------------------------------------------------------------- Comment By: Evgeniy (mrcoder1234) Date: 2006-01-07 09:31 Message: Logged In: YES user_id=1132996 It will be good see this feature in the next release. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-01-06 23:29 Message: Logged In: NO Very strange behaviour when xmms is started. ---------------------------------------------------------------------- Comment By: Thomas Holder (speleo3) Date: 2006-01-05 12:09 Message: Logged In: YES user_id=1306887 Changes in 0.3: * only considers windows in layers "Below" to "Dock" (ignores stuff like desktop icons and taskbar) * window colors are adjusted to button bg/fg * two new pref options: TaskBarWorkspacesShowBorders=1 TaskBarWorkspacesShowNumbers=1 ---------------------------------------------------------------------- Comment By: Adam Pribyl (covexx) Date: 2006-01-03 22:50 Message: Logged In: YES user_id=607018 This is very nice feature. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300031&aid=1394863&group_id=31 |