Hi!
After looking closer on the sample files I've come to the conclusion that twinkle.ics and twinkle_orig.ics should be moved to the invalid folder. They both contain a property named X. This is not valid x-names according to the rfc and should be refused. I have some patches in preparation to add this and some other validation features.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
That's fine, although if you have further changes to the source could I ask that you wait for a bit before generating the patch (cvsdiff) files, as I've got quite a few changes coming into CVS shortly (regarding merging the DateRange/Period classes).
I'll post somewhere here when the changes are committed.
regards,
ben
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Ben
Have you had a chance to look at my patches from a few days ago? I've done some more work since then, fixed some minor bugs, added some stuff from the spec that wasn't implemented (iana-comp and x-comp and more) and added a few extra featues such as implemented equals most of the relevant classes. Since these new changes build on what I already submitted it would simplify my work if the submitted changes could go into cvs.
best
/Tobias
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've just had a look at it now and have added some feedback comments to the patch.
Basically some of the patching didn't work so I've got some cleaning up/manual patching to do. I've committed the changes that are ok, but there's still a couple of packages with uncommitted changes.
If you want to create a new patch now you can, just don't include the following folders:
Hi!
After looking closer on the sample files I've come to the conclusion that twinkle.ics and twinkle_orig.ics should be moved to the invalid folder. They both contain a property named X. This is not valid x-names according to the rfc and should be refused. I have some patches in preparation to add this and some other validation features.
Hi Tobias,
That's fine, although if you have further changes to the source could I ask that you wait for a bit before generating the patch (cvsdiff) files, as I've got quite a few changes coming into CVS shortly (regarding merging the DateRange/Period classes).
I'll post somewhere here when the changes are committed.
regards,
ben
Tobias,
My changes are in CVS now so feel free to provide patches.
b.
Hi Ben
Have you had a chance to look at my patches from a few days ago? I've done some more work since then, fixed some minor bugs, added some stuff from the spec that wasn't implemented (iana-comp and x-comp and more) and added a few extra featues such as implemented equals most of the relevant classes. Since these new changes build on what I already submitted it would simplify my work if the submitted changes could go into cvs.
best
/Tobias
Hi Tobias,
I've just had a look at it now and have added some feedback comments to the patch.
Basically some of the patching didn't work so I've got some cleaning up/manual patching to do. I've committed the changes that are ok, but there's still a couple of packages with uncommitted changes.
If you want to create a new patch now you can, just don't include the following folders:
source/net/fortuna/ical4j/model/
source/net/fortuna/ical4j/model/property/
test/net/fortuna/ical4j/
test/net/fortuna/ical4j/data/
I'll try to sort these out in the next 24 hours - will let you know when its done.
regards,
ben