Re: [Iaxclient-devel] Negative number of calls - patch

[Steve K. <st...@st...>]

Marcin Zajączkowski wrote:

> Hi,
>
> If as second param of iaxc_initialize() developer uses negative value 
> then there will be "Fatal error: can't allocate memory" and probably 
> segmentation fault in many programs.
> I wrote little patch which sets 1 (default value?, maybe there should 
> be constant like IAXC_DEFAULT_NUMBER_OF_CALLS) for every <=0 value 
> (not only ==0) and I think it could be commited to CVS.
>

JeffG committed this for me earlier.

I do have to say, though, that iaxclient presently does not protect 
itself from stupid input from the application which uses it -- and 
asking to be initialized to handle -5 calls seems like something pretty 
silly.

It will also similarly crash in thousands of spectacular ways, if, for 
example, you pass it invalid pointers, unterminated strings, etc.  There 
is lots of invalid inputs that a library just can't check for.

-SteveK