Re: [Haskelldb-users] Request for code review: Patch removing "distinct" option, adds "unique" function

[Peter G. <pe...@gm...>]

On 27/12/2007, at 1:19 AM, Justin Bailey wrote:

> On Dec 21, 2007 9:32 AM, Peter Gammie <pe...@gm...> wrote:
>> I can email you (== anyone who's interested) a patch that begins down
>> that road. Roughly, I added support for defaults, foreign keys and
>> primary keys. IIRC one can create tables with those things but the
>> reflection is a bit weak, and the data description types are not
>> fantastically robust. (The fieldnames are merely strings, e.g.)
>
> Sounds interesting, though I'm probably more interested in the
> reflection/representation side. Were those relationships able to be
> used in queries? In any case I wouldn't mind seeing the code.

I've attached two patches.

One is for this constraint stuff. It's for describing tables only, not  
for use in queries. (What do you have in mind? The possibility of  
doing natural joins?) It probably depends on some changes to the HSQL/ 
PostgreSQL driver that should be fairly obvious. I can send that patch  
along too if you want it. Note that the other backends do not conform  
to my changes to the types.

There is probably a lot of GHC warning elimination in that patch too.

The other fixes the expression generator - it does not generate enough  
parentheses for boolean expressions (at least). Bjorn, please adjust  
to taste and commit.

cheers
peter