[Hamlib-developer] Re: [ANN] Hamlib 1.1.3 released

[Riley W. <rhw@InfraDead.Org>]

Hi Stephane.

>>> Hamlib-1.1.3 has finally been released.
>>> Check it out at http://www.hamlib.org !

>> This announcement appears to be premature as the download link from
>> the page specified only shows 1.1.1 as being available. Can somebody
>> clarify that please?

> The web site has not been updated yet. However, tt seems some clever
> guys still managed to find the download page :)

Quite clearly, I'm not one of them...

>>> Note: locator calculation is not working right.

>> What exactly is the problem?

>=09(fillods@charybde:tests)$ ./testloc IN98EC DM33DX
>=09Locator1: IN98EC
>=09Longitude: -0.666667, -1=B0 40' 0"
>=09Latitude:  48.083333, 48=B0 5' 0"
>=09Recoded: IN98QC
>
>=09Locator2: DM33DX
>=09Longitude: -112.750000, -113=B0 45' 0"
>=09Latitude:  33.958333, 33=B0 57' 30"
>=09Recoded: DM33PX
>
>=09Bearing: 8677.35km
>=09Azimuth: 51.782422, 51=B0 46' 56"
>
> Have you noticed ? The recoded locator is broken.=20

Not by my calculation - the recoded locator perfectly matches the
DMS coordinates given.

> AFAIR, dec2dms() in src/locator.c is broken, unless it is longlat2locator=
=2E

Looking at the above, there are two obvious bugs:

 1. dec2dms() is returning the wrong value when given a negative
    input value. Both negative longitudes are out by exactly 1=B0,
    but the positive latitudes are both correct.

 2. The value labelled "Bearing" is not a bearing, but a distance.

> Sorry, I can't fix it right now, I have to look after some prolific
> cvs commiter, but feel free to send us a patch. You're more than
> welcome!

If you can advise where I can download the source from, I will...

Best wishes from Riley.