From: Sikon <ine...@gm...> - 2008-01-02 13:21:10
|
> very good job > > some things need tuning: > > 1. warnings on open > I get two warnings when opening the new prefs window: > (gtkpod:8494): Gtk-WARNING **: Only 'activatable' widgets can be > packed into the action area of a GtkDialog > > (gtkpod:8494): Gtk-WARNING **: Only 'activatable' widgets can be > packed into the action area of a GtkDialog > > 2. subwindows can be hidden by main window > All subwindows that open when clicking buttons in the prefs window are > modal but aren't kept on top of their parent (eg open "Preferences > Window", click "Sorting", then you can bring the main prefs window to > the front, possibly hiding the subwindow) > > 3. assertion failed when clicking "remove" buttons > when no item is selected, clicking the remove buttons for "Displayed > Columns" and "Excluded Files..." > (gtkpod:8494): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion > `path !=3D NULL' failed > > 4. assertions failed opening the "Commands..." subwindow > (gtkpod:8524): GLib-GObject-CRITICAL **: g_object_unref: assertion > `G_IS_OBJECT (object)' failed > > (gtkpod:8524): Gtk-CRITICAL **: gtk_file_system_unix_get_parent: > assertion `g_path_is_absolute (filename)' failed > > (gtkpod:8524): GLib-GObject-WARNING **: gsignal.c:1669: signal > `file_set' is invalid for instance `0x85d1160' > > 5. when closing the "Encoding..." and Tags/"Customize" subwindows > (gtkpod:8524): GLib-GObject-CRITICAL **: g_object_unref: assertion > `G_IS_OBJECT (object)' failed > > 6. I got a number of identical warnings about columns, but I'm not > able to reproduce them > (gtkpod:8524): Gtk-WARNING **: gtkliststore.c:737: Invalid column > number -1077094488 added to iter (remember to end your list of columns > with a -1) I knew about #1 and #2. #1 is recent, introduced with the Revert button. Previously, when I had jus= t=20 the Help and Close buttons, I set the placement style of the button box=20 to "Edge". Now I needed to do some hacky tricks with hboxes to correctly=20 position the Help, Revert and Close buttons. If somebody knows a better way= ,=20 please tell me how, or edit the glade file yourself. As for #2, I didn't know how to fix. Now I know: using=20 gtk_window_set_transient_for. I'll commit the fix soon. The others I didn't know about. I'll look into them. Thanks! |