From: Simon N. <sna...@gm...> - 2007-02-03 16:40:08
|
Hi All, Attached is a patch for the following: 1) Convert from ogg, flac, mp3, m4a and wav to whatever script you select in preferences 2) Convert preferences have a check box in front of them to turn conversion on and off. - probably not a good idea for flac and ogg, so may need removing or someother approach? 3) Added a "details" expander and a textview below the copying tracks progress bar which is updated from the conversion scripts stderr so the user can watch the output from the command line converter tool. Displays nothing if tracks are just being copied. 4) Modified the conversion scripts so that the tags are passed as parameter= s. Cheers, Si. On 1/29/07, Jorg Schuler <jor...@gm...> wrote: > > 1) As mp3 files and wav files can be played natively on an ipod > > conversion is obviously not required as it is for flac and ogg, so is > > the presence or abscense of a value in the MP3 and WAV entry boxes in > > the On-The-Fly Conversion section of the preferences dialog enough to > > determine if the file should be converted or not? IOW, should there be > > "Convert MP3" & "Convert WAV" check boxes (or similar) as well? > > I already thought about adding a checkbox in front of the conversion scri= pt selection box. > > > 2) As M4A is (IMHO) the best all round format for the ipod am I right > > to not bother with a "Convert M4A" option? > > I think if we add wav and mp3, m4a should be there as well. > > > 3) At the moment the conversion scripts take a single parameter which > > is the file name to convert. Command line tools (metaflac, ogginfo > > etc) are used to determine the tags and copy them to the converted > > file. This is ok until we come to tag-less WAV files. Other than > > parsing the file name directory structure in exactly the same was as > > specified in preferences - which would be a right pain in the > > proverbial - there is no way to obtain the tag info inside the script. > > As we already have tag information in the _Itdb_Track/Track structure > > it may be better to pass this information to the conversion scripts? > > e.g. > > > > conversion-script 'file_name' 'title' 'tracknum' 'album' 'artist' > > 'genre' 'comment' > > > > Using fixed parameters e.g. $1 always =3D file name, $2 always =3D titl= e > > would make parsing the command line easier. Passing "" as an empty > > parameter avoids any parameter positioning problems. > > > > Obviously this will mean rewiting the scripts (not a big drama). > > > > The only downside I can think of is just the added complexity of users > > adding their own scripts - but then... anyone capable of writing a > > script should understand this stuff anyway(?). > > > The current situation with the scripts is only temporary anyway. I'd pref= er to have "--album=3Dsomething" parameters instead of the fixed thing. Who= ever will write a new script can simply copy the part with the command line= parsing. > > Cheers, > > > JCS. > -- > What's the difference between eating sugar (e.g. candy bar) and > eating carbon hydrates (let's say a loaf of bread)? > > > Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! > Ideal f=FCr Modem und ISDN: http://www.gmx.net/de/go/smartsurfer > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share y= our > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D= DEVDEV > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel > |