From: Jorg S. <Jor...@gm...> - 2006-09-12 13:41:44
|
Hi Marcelo, Marcelo Varanda wrote: > Hi Jorg, > > I was willing to use the right side to add a small panel to control the > player in the future. However, I can move the buttons to the right now > and by the time the panel is added then re-arrange the entire bar. > However, users might be a bit lost with this lay-out changes as I do not > think I will add this panel anytime soon. Please confirm what you would > like better and then I will change that accordingly. I'm getting confused by having the buttons on the left side, so by just moving them to the right, maybe with a separator bar, should be a good start. > Lock edit cells: I think the best option would be a simple "edit" > command in context menu (no need lock/unlock and disregard click events > for getting into that mode). I'm still trying to come up with something different. > note: it might get difficult to separate patches (well... not for this > one). We would need to have as many as CVS copies for each new feature. > We might also have dependencies over incremental changes making it even > harder. I would appreciate your suggestion in how to keep patches isolated. Two ways, I guess: 1) keep different checkouts. 2) once you created a patch, un-apply it (patch -R) and continue with the next one. Patches may collide, but this happens fairly rarely. In these cases the rejected hunks have to be combined manually. Not really a problem in almost all cases. > btw... I could not find yet a Brazilian to translate gtkpod (and lib) to pt. Thanks for trying! Cheers, JCS. > Cheers, > Marcelo > > */Jorg Schuler <Jor...@gm...>/* wrote: > > Hi Marcelo, > > I've finally found time to look at your patch. > > I think the "Next" button should actually select and play the next > track, not just select it. The buttons should be on the right side, not > the left. "//" cannot be used to indicate comments, use "/*...*/" > instead. The patch should address the prev/next/play buttons only, not > the cell edit feature -- I'm trying to think of something else. > > If you send a revised patch I think I will submit it to CVS. > > Cheers, > > > JCS. > > > Marcelo Varanda wrote: > > - The current Play Button in my patch does the same then Play cmd in > > Context menu; > > > > - "Next" >>, selects next track (from latest selected row); > > > > - "Prev"<< , selects prv. track (from latest selected row); > > > > The << and >>buttons do not interact with playlist in progress. > > > > If you have chance apply the patch and play with those cmds a bit. > > Cheers, > > > > > > */Jorg Schuler /* wrote: > > > > Marcelo Varanda wrote: > > > "The Next/Prev buttons should actually play the next/Prev entry, I > > > would think." > > > > > > I am thinking that it might be better just leave the "Play" button > > > (remove Next/Prev as it might be confusing). > > > > Sorry, now I'm confused. What good should the Play button alone > do? It > > wouldn't even be clear what it would play (selected playlist, tab > > entry, > > track(s)? Then I'd definitely prefer the context menu. > > > > A quick way to listen to the selected tracks and move > forward/backward > > from within gtkpod would certainly be convenient. > > > > JCS. |