From: James L. <jrl...@co...> - 2006-08-31 21:17:40
|
On Thu, 2006-08-31 at 21:31 +0100, Richard Hyde wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi All, > > An improved excldes files mask patch should be attached, Indeed, this one seems to be a pretty big improvement. But, I've got just one small style comment. It would be more consistent with the rest of the gtkpod source tree if you didn't use a prototype in file.h for your excludefile function. In most other places, static functions are defined in the source file that they're used in, usually either somewhere near the beginning of the source file. Usually prototypes aren't used for static functions (in gtkpod at least ;-) > Upgrading glade to 2.12.1 sorted out the issues with gtkpod.glade. Good to see you got that fixed :) Keep up the good work, James |