Re: [Gtkpod-devel] prefs file badness

[James L. <jrl...@co...>]

On Tue, 2006-05-30 at 23:56 -0400, Todd Zullinger wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> After updating to the latest CVS I find that gtkpod will erase my
> itdb_* settings on every start.  Looking at the code a little it seems
> that the prefs file isn't written without version being the first
> entry.  As such, in read_prefs_from_file_desc() when if cfg->version <
> 0.91 is reached (line 2257), cfg->version is null and the test is
> always true so the itdb_* entries are skipped.
Actually, that isn't the case. If that were true, then all of the prefs
I moved over to the new system wouldn't be working. I did some
debugging, and I found out that it's reading the keys as it's supposed
to. But I can reproduce the bug you're talking about, so something's
going on :(. 
> 
> Is there a simpler fix for this than to back out the change that
> disables reading of the new prefs system?
Unfortunately, no. I would have rather just had the two systems do the
reading/writing on their own like I originally had it, but that made it
so that prefs are read/written twice. Although this worked for most
everything, Jorg didn't like the idea of each key being read twice.
> 
> Speaking of that, perhaps someone can enlighten me on cvs usage.  In
> subversion I would look at the log and see what revision made that
> change and easily do a diff to get all the changed files in that
> revision.  In cvs each file maintains its own revisions, so I need to
> look at both src/prefs.c and src/main.c to do a diff by reversion
> number.  That's a pain so I find myself using the date instead.  Is
> there an easier way that I'm overlooking?
AFAIK there's no better way :( I end up using cvs up -D a lot too! ;-)

I'll see if I can track this one down. I think it might be a sort of
repository bug, but I'm not 100% on that ATM. I'll check into it. Thanks
for the report.

James

> 
> - -- 
> Todd        OpenPGP -> KeyID: 0xD654075A | URL: www.pobox.com/~tmz/pgp
> ======================================================================
> Moderation in temper is always a virtue; but moderation in principle
> is always a vice.
>     -- Thomas Paine, Common Sense
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: When crypto is outlawed bayl bhgynjf jvyy unir cevinpl.
> 
> iG0EARECAC0FAkR9E/YmGGh0dHA6Ly93d3cucG9ib3guY29tL350bXovcGdwL3Rt
> ei5hc2MACgkQuv+09NZUB1qPkACgkF/SGmcM/HiHVPVeSkBFtMkofUQAnjecDQaK
> AxZrKtoDnBntHvbg/KKl
> =CCVX
> -----END PGP SIGNATURE-----
> 
> 
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel