[Gtkpod-devel] filename_ipod removed from iTunesDB.ext?

[Todd Z. <tm...@po...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jorg, all,

Occasionally I have a desire to compare a file on my ipod with the one
on the hard drive.  Using the filename_ipod field in iTunesDB.ext
makes this simple.  But between revistion 1.70 and 1.71 this
disappeared.  Was that intentional or did it just get lost in the
larger part of the changes there?

The commit message was "save thumbnail filename in .ext database"

Here's a link to diff those revisions:

    http://cvs.sourceforge.net/viewcvs.py/gtkpod/gtkpod/src/file_itunesdb.c?r1=1.70&r2=1.71&diff_format=u

Anyway, if it wasn't intentional to remove that field, here's the
trivial patch to put it back:

Index: src/file_itunesdb.c
===================================================================
RCS file: /cvsroot/gtkpod/gtkpod/src/file_itunesdb.c,v
retrieving revision 1.73
diff -u -r1.73 file_itunesdb.c
- --- src/file_itunesdb.c	4 Feb 2006 12:04:52 -0000	1.73
+++ src/file_itunesdb.c	21 Feb 2006 17:38:51 -0000
@@ -927,6 +927,8 @@
 	  fprintf (fp, "thumbnail_utf8=%s\n", etr->thumb_path_utf8);
       /* this is just for convenience for people looking for a track
 	 on the ipod away from gktpod/itunes etc. */
+      if (strlen (track->ipod_path) != 0)
+	  fprintf (fp, "filename_ipod=%s\n", track->ipod_path);
       if (etr->md5_hash && *etr->md5_hash)
 	  fprintf (fp, "md5_hash=%s\n", etr->md5_hash);
       if (etr->charset && *etr->charset)

If it was intended to be removed, any reason why?

Thanks as always for the cool software.

- -- 
Todd        OpenPGP -> KeyID: 0xD654075A | URL: www.pobox.com/~tmz/pgp
======================================================================
The more laws, the less justice.
    -- Marcus Tullius Cicero "De Officiis", 44 B.C.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: When crypto is outlawed bayl bhgynjf jvyy unir cevinpl.

iG0EARECAC0FAkP7Ul8mGGh0dHA6Ly93d3cucG9ib3guY29tL350bXovcGdwL3Rt
ei5hc2MACgkQuv+09NZUB1rP/gCgrYjqTSbfhacsx5xpeL9XxmAwkq8AoOx3oZMe
Tufqdc+wS190NwczFAXM
=jNY9
-----END PGP SIGNATURE-----