From: Christophe F. <cfe...@gm...> - 2010-09-02 19:08:55
|
On Thu, Sep 02, 2010 at 12:45:30PM -0600, Joel Smith wrote: > I have just pushed some new commits up to my sandbox at > http://gitorious.org/~joelsmith/libgpod/joelsmith-sandbox > I removed the old commits for chapter support and wcontents and > refactored the code to use a helper function instead. IMHO, this > approach is cleaner and more straight-forward than what I had before. Ah good to know, I'll look at it then :) > > I tested this code and found a bug which caused all integer values to > become zero since the types didn't match in get_int. I have a proposed > fix in my sandbox. It's here: > http://gitorious.org/~joelsmith/libgpod/joelsmith-sandbox/commit/34d0fe3f66a9f361c330c1cf7279a3a40b1f30e8 > Maybe we should squash all three gint64 plist commits into one before > applying it to master. Thanks a lot for debugging this, I always feel bad when I let others do the dirty work :-/ Yep, I'll squash them, I didn't do it initially so that you can see more easily what was changed compared to your patch. Christophe |