Re: [Gtkpod-devel] [PATCH] Fix memory leak reported by valgrind.

[Javier K. <jk...@gm...>]

On Wed, Mar 31, 2010 at 22:17, Javier Kohen <jk...@gm...> wrote:

> Watch out there, you are freeing that pointer and then you dereference it
> three lines below.


Never mind, my bad; I just noticed it's re-initialized in between. Sorry for
the noise.


>
> On Tue, Mar 30, 2010 at 22:08, Andrea Odetti <mar...@go...>wrote:
>
>> ---
>>  src/file_itunesdb.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/file_itunesdb.c b/src/file_itunesdb.c
>> index 5679127..d33c948 100644
>> --- a/src/file_itunesdb.c
>> +++ b/src/file_itunesdb.c
>> @@ -2002,6 +2002,7 @@ static gboolean gp_write_itdb (iTunesDB *itdb)
>>              gchar *ipod_model = get_itdb_prefs_string (itdb,
>> KEY_IPOD_MODEL);
>>              gchar *backup_name = g_strconcat ("backupDB_", ipod_model,
>> NULL);
>>              g_free (ipod_model);
>> +             g_free (eitdb->offline_filename);
>>              eitdb->offline_filename = g_build_filename(cfgdir,
>> backup_name, NULL);
>>              g_free (backup_name);
>>              gtkpod_warning ("Backup database could not be found so
>> backing up database to %s\n", eitdb->offline_filename);
>> --
>> 1.6.2.5
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Gtkpod-devel mailing list
>> Gtk...@li...
>> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>>
>
>