From: Michael T. <ti...@ti...> - 2010-01-24 08:28:46
|
On Sun, 2010-01-24 at 01:31 -0500, John Regan wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I had problems with gtkpod detecting if my files were supposed to be > gapless or not - gapless MP3s kept not having the gapless flag checked. > > I tried running gtkpod through gdb, and figured out that my files were > returning with a postgap of zero. On a hunch, I tried changing the > logic to determine if a gap is valid or not to just check if either the > postgap or the pregap is something other than zero. > > After doing this, I was able to update information on my MP3s, and have > my iPod play them back correctly, without gaps. > > I have attached to this email a small patch I made (it only changes one > line!) against mp3file.c. I'm hoping it will add clarity to my message. > > I'm not sure if this is an error in logic, or an error in determining a > postgap (I have no idea if a postgap of zero is allowed!), but I thought > I'd do what I can to help! > > You'll have to excuse me if I'm submitting this to the wrong list, or if > I shouldn't be submitting this to a list at all - this is my first time > trying to submit anything to an open-source project. > > I'm currently using the git-repository version of gtkpod, and an iPod > 5G (30GB) with firmware version 1.3. If I understood the sourceforge > website correctly, I think I need to ask to be CC'd on reply emails. > Again, this is my first time doing anything like this, so please excuse > me if I'm breaking any protocol or netiquette. > > If you need any further files from me, let me know, and I'll be glad to > help in any way I can :) Etiquette is fine, nothing to worry about. Are you consistently getting a postgap of 0 (for most/all files)? I *think* that a postgap of 0 should be invalid, but at the very least, it should be highly unlikely to happen consistently. Just to verify, were these mp3 files encoded with LAME? LAME is the only encoder currently supported. I just checked my repository, and the latest mp3s I've added don't have the gapless flag set either. That being said, there was a bug affecting gapless that was fixed about a year ago that I'm not sure made it into ubuntu yet, so that's most likely my problem. If you're using the latest git, that shouldn't be it. Do you have web space to upload one of the mp3 files? I'd like to get a look at the lame tag and make sure it looks ok. If you don't, you could email one directly to me (bypass the list) or I can give you a server to upload to. Michael -- Michael Tiffany ti...@ti... http://www.tiffman.com |