From: Dudy K. <ko...@gm...> - 2009-04-17 16:04:58
|
On Fri, Apr 17, 2009 at 5:59 PM, Todd Zullinger <tm...@po...> wrote: > Dudy Kohen wrote: > > Thanks for the heads up regarding the summary and conflict markers, > > but I don't like the other changes and I'll tell you why: > > > > 1. Currently, we still need libid3tag since your changes require it, > > so it won't compile otherwise... > > Which changes? Are they for things that are committed to SVN already? > If not, then they don't really matter. They are in the SVN, I'm talking about your soundcheck code, it uses libid3tag, doesn't it? > > > > 2. It's simpler to redefine something to a different value for > > debugging code segments than undef\define (easier to follow) > > I don't think that's what belongs in the repository though. It's > crufty feeling, IMO. > The redefinitions wouldn't be in the repository, just in the sandboxes, I believe it's simpler to debug as it is now, and since I'm the one that coded these changes, I think odds are that bugs found there will be mine to debug. > > > 3. I still need to redefine frame IDs that exist in id3tag's > > headers. (which is not urgent since we still need it for your > > changes) > > I don't see what value there is to requiring both taglib and > libid3tag. We should adapt any code to work with either one. Then, > after taglib is enabled and tested for a while, we can just remove the > libid3tag code. I will cleanup the code after you'll test if the soundcheck (replaygain) code works with taglib, I have no idea which program writes this info to ID3 tags... > > > That's just my opinion though. :) > > -- > Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp<http://www.pobox.com/%7Etmz/pgp> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Learn from the mistakes of others--you can never live long enough to > make them all yourself. > -- John Luther > > > > ------------------------------------------------------------------------------ > Stay on top of everything new and different, both inside and > around Java (TM) technology - register by April 22, and save > $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. > 300 plus technical and hands-on sessions. Register today. > Use priority code J9JMT32. http://p.sf.net/sfu/p > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel > > |