From: Peter G. <pg...@gm...> - 2007-07-26 14:08:50
|
Sorry about that... I always forget to hit "reply to all". I wish I could make GMail could let me make it default or something :) Oh, and Thanks, Axel. Pete On 7/26/07, Axel Simon <A....@ke...> wrote: > From Pete: > > > On 7/25/07, Axel Simon <A....@ke...> wrote: > >> It's a big patch. Geez. I'm slightly worried that whatever comment I > >> make incurs a lot of work. It looks like you're re-invented the wheel > >> of the methods in GObject, namely constructNewGObject and > >> makeNewGObject. As a consequence, I think you export some low level > >> functions to the end-user, that shouldn't really be accessible. > > > > Don't worry about how much work a change is, I'd rather make > > everything consistent and have you guys be happy with my changes. I > > was going to use constructNewGObject/makeNewGObject, but GStreamer > > uses floating references. I suppose I could replace the per-type > > functions with a single function, though. As far as exports, I'm very > > careful about what actually gets exported to the user. The end user > > doesn't get the low-level functions. > > > >> Do I see that correctly? Also, could you say what you had to change > >> in the type generator? I don't think you needed to, it should all > >> work out of the box for other libraries. E.g. the sourceview library > >> is separate but its types are build by the same tools. > > > > Well, one thing I added was the isObject functions, which act like > > GTK_IS_OBJECT etc. I suppose I could remove the withObject functions > > I added and replace them with a single function. Also, GStreamer has > > a hierarchy of objects that aren't derived from GObject, they actually > > created a new root-object called MiniObject. So I had to add a --root > > parameter that makes the type generator use the argument as the root > > instead of GObject. > > > > Thanks for looking at my work, I really appreciate it! :) > > > > Pete > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Gtk2hs-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel > |