From: Axel S. <A....@ke...> - 2005-10-17 08:20:10
|
Things to do before the release: - tidy up the naming in the Cairo module... I can't actually think of anything else. Pango is nearly complete; it would be possible to complete it, what's lacking is: - tab stops (~9 functions) - Font and FontSet; both not useful in practise as far as I can see So maybe that's something to do. apiGen only gives me a skeleton, it doesn't actually bind any function properly. But then it's fewer than 10 functions. As to the naming issue: On Sun, 2005-10-16 at 16:54 +0100, Duncan Coutts wrote: > > I renamed this to 'area'. Now 'area' and 'region' are already defined > > in 'Event' (in Widget), so I hid them in Gtk.hs. I added a comment > > that one has to import these two names qualified. > > > Tell me if that's ok, we can always revert. > > I'm rather of the opinion that all the event record names should be > qualified with their event name. It's really not ok to export such > generic names as "x" and "y". Ok. That makes sense. We could force the user to import Graphics.UI.Gtk.Gdk.Events explicitly. It's just that the name is quite a mouthful. We could introduce some sort of "Graphics.UI.Gtk.LowLevel" module (but we can always do so later). > For the specific case of the Gtk rectangle it's almost so simple as to > be pointless. The region one is useful however. We could get away with > removing the gtk rectangle one after all, look at it's code: > > cairoRectangle (Rectangle x y width height) = > Cairo.rectangle (realToFrac x) (realToFrac y) > (realToFrac width) (realToFrac height) > > It's just converting Int -> Double and calling the existing cairo > rectangle api function. And the Haskell binding doesn't even use the Gtk > Rectangle thing very much. I doubt people would miss the function if we > removed it. Ok, on the other hand, we can keep it, and the 'region' if we just make Events a qualified export. > > Another thing: There are these "primitive" text functions in the cairo > > binding. It might be better to remove those, so that we don't confuse > > people too much. Pango works well now with Cairo - I changed the demo so > > that it only uses Pango. The rotation matrix works fine, too! > > Hmm, I think we'll need to keep the "toy" text api since people using > cairo without gtk will need it. However we should make clear in the > documentation that it is only the toy api and refer them to the > pango/cairo module. Yes, a comment is probably sufficient. In case Cairo gets factored out of Gtk2Hs again, we need to convince people that they keep the comment. If you say yay to all these, I will proceed. Axel. |