From: Eugene K. <eki...@gm...> - 2011-11-03 09:02:20
|
Hi, The actual thanks for tracking this down go to Vincent Hanquez for finding that we're doing a lot of gmp calls (and for making me aware of ltrace), and to Felipe Lessa for finding that this is caused by poor code generated for cFloatConv :) Your changes look identical to those that I made in my copy. On Thu, Nov 3, 2011 at 11:41 AM, Axel Simon <Axe...@in...> wrote: > Hi Eugene, > > > On 02.11.2011, at 17:34, Eugene Kirpichov wrote: > > Heh. >> >> Guess what! >> A simple {-# INLINE cFloatConv #-} helped to the same extent! >> >> Axel, I think this change should be pretty easy to incorporate, and it >> probably makes sense to inline all other functions in Types.chs too. >> >> > I've added INLINE pragmas to all these odd c2hs marshalling functions. > Could you pull and check if I've done it correctly? > > Thanks for tracking this down! > > Axel > > > Would you like me to send the trivial darcs patch or the gtk2hs team >> will take care of this? >> >> On Wed, Nov 2, 2011 at 7:29 PM, Felipe Almeida Lessa >> <fel...@gm...> wrote: >> >>> On Wed, Nov 2, 2011 at 11:24 AM, Jean-Marie Gaillourdet >>> <jm...@ga...> wrote: >>> >>>> Hi Eugene, >>>> >>>> did you try using the SPECIALIZE pragma? It is part of the Haskell 98 >>>> and Haskell 2010 specifications. >>>> >>> >>> I don't think it's going to make any difference, as the core already >>> have an specialized poor version. See my first e-mail. >>> >>> -- >>> Felipe. >>> >>> >> >> >> -- >> Eugene Kirpichov >> Principal Engineer, Mirantis Inc. http://www.mirantis.com/ >> Editor, http://fprog.ru/ >> > > -- Eugene Kirpichov Principal Engineer, Mirantis Inc. http://www.mirantis.com/ Editor, http://fprog.ru/ |