From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-02 22:16:42
|
https://bugzilla.gnome.org/show_bug.cgi?id=609932 gnome-perl | Gnome2::Rsvg | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153775|none |needs-work status| | --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2010-03-02 22:16:28 UTC --- Review of attachment 153775: --> (https://bugzilla.gnome.org/review?bug=609932&attachment=153775) Thanks for the patch (in git form even!). Just two things that need fixing before it can go in: * Since typemaps are public, and the new typemap uses a new converter, we need to properly export this converter via rsvg2perl.h. * The new methods need tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |