Re: [Gtk-gnutella-devel] [PATCH] Latest Bitzi code with GTK1 support now.

[Christian B. <chr...@gm...>]

alex wrote:
> Uploaded the latest for bitzi support to SF:

I've tested the patch with GTK+ 2.x. I fixed some warnings locally - all
developers should really use "-W -Wall -Wformat=3D2 -Wno-unused-parameter"
when compiling with GCC. Works just fine as far as I can see. The
presentation format could be improved. Everything in a single line looks a
little cluttered. It would be nice if the metadata was split so that you
have one piece of information per line. I don't know whether that's
easily to do with GTK+. The metadata column should be sortable by goodness
and/or judgement. With respect to the core part, GTKG should use keep-alive
and/or pipelined HTTP requests to lower the load/traffic for bitzi.com. I
haven't really looked at the relevant HTTP code but I doubt it does this
already.

Anyway, if you fix the indentation and someone checks the GTK+ 1.2 frontend,
your bitzi patch can and should be committed to CVS.

--=20
Christian