From: <bug...@wi...> - 2003-06-02 22:08:37
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=114216 Changed by ds...@sc.... --- shadow/114216 Mon Jun 2 15:52:53 2003 +++ shadow/114216.tmp.23819 Mon Jun 2 18:08:33 2003 @@ -49,6 +49,38 @@ Wow :) - g_warning ("%s: state change in cllback %d %d", + g_warning (_("%s: state change in cllback %d %d"), Prolly you could fix that "callback" typo too while at it. ;-) + +------- Additional Comments From ds...@sc... 2003-06-02 18:08 ------- +If you created this patch using a perl/python script, that's pretty +cool. However, it gets a few things wrong, like this: + +@@ -954,8 +958,8 @@ + g_return_val_if_fail (GST_PAD_PARENT (realsink) != NULL, FALSE); + + if (!gst_pad_check_schedulers (realsrc, realsink)) { +- g_warning ("linking pads with different scheds requires " +- "exactly one decoupled element (queue)"); ++ g_warning (_("Linking pads with different scheds requires ") ++ _("exactly one decoupled element (queue)")); + return FALSE; + } + + +Anyway, that's mostly irrelevant, since such cases can be easily fixed +by hand. + +Actually commenting on the patch -- GST_INFO() and GST_DEBUG() should +not be translated, since it is entirely internal debugging. + +Usage of g_print() in gstreamer and plugins is discouraged. These +should either be changed to GST_DEBUG(), GST_INFO(), or g_warning(). + +Of course, g_warning() should be translated. + +GStreamer has more of a problem with not having _good_ messages, +compared with actually i18ning them. There's a discussion on the +gstreamer-devel mailing list currently about error reporting. + |