From: <sa...@ke...> - 2010-07-30 09:41:13
|
Module: gst-plugins-bad Branch: master Commit: d564e1bf19cbeb4bd5aae9cbf92b79445fde96c8 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=d564e1bf19cbeb4bd5aae9cbf92b79445fde96c8 Author: Carl-Anton Ingmarsson <ca....@gm...> Date: Tue Jul 27 23:17:09 2010 +0200 vdpau: fix GstBaseVideoDecoder returning wrong GstStateChangeReturn when gst_base_video_decoder_[start|stop] fails we now return GST_STATE_CHANGE_FAILURE instead of returning what the parent class returns --- sys/vdpau/basevideodecoder/gstbasevideodecoder.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/vdpau/basevideodecoder/gstbasevideodecoder.c b/sys/vdpau/basevideodecoder/gstbasevideodecoder.c index 353badf..1e9cf14 100644 --- a/sys/vdpau/basevideodecoder/gstbasevideodecoder.c +++ b/sys/vdpau/basevideodecoder/gstbasevideodecoder.c @@ -917,7 +917,8 @@ gst_base_video_decoder_change_state (GstElement * element, switch (transition) { case GST_STATE_CHANGE_READY_TO_PAUSED: - gst_base_video_decoder_start (base_video_decoder); + if (!gst_base_video_decoder_start (base_video_decoder)) + return GST_STATE_CHANGE_FAILURE; break; default: @@ -928,7 +929,8 @@ gst_base_video_decoder_change_state (GstElement * element, switch (transition) { case GST_STATE_CHANGE_PAUSED_TO_READY: - gst_base_video_decoder_stop (base_video_decoder); + if (!gst_base_video_decoder_stop (base_video_decoder)) + ret = GST_STATE_CHANGE_FAILURE; break; default: |