From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-01-29 19:41:35
|
https://bugzilla.gnome.org/show_bug.cgi?id=608398 GStreamer | gstreamer (core) | git --- Comment #10 from Sebastian Dröge <sl...@ci...> 2010-01-29 19:41:21 UTC --- (In reply to comment #9) > I see, you're right. > > Ok, I think what we should do is this: > > * for the release, don't put -DG_THREADS_MANDATORY > into the pkg-config CFLAGS, just use it internally > > * for the release, disable the warning if runtime version > of glib is >= 2.23.2, since then we know late g_thread_init > will be fine and be done in g_type_init() anyway Ok, sounds good to me. > * after the release guard the warning with > #ifdef GLIB_CHECK_VERSION(2,23,2) so > that it is removed entirely if GStreamer is compiled > against a new glib. I'd leave it as a runtime check, that's safer ;) > * after the release, see if we want to put the > -DG_THREADS_MANDATORY back into our pkg-config > cflags (it doesn't seem 100% kosher to me) Well, maybe it's not nice if we add it to our pkg-config files. We could add it to GLIB_CFLAGS in common/m4/gst-glib2.m4 and then it's at least used for all of our code and other applications are not affected. What do you think? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |