From: <sl...@ke...> - 2009-10-13 14:02:03
|
Module: gst-plugins-bad Branch: master Commit: 7eb553e2debfd279d6b1b6fc95b90cdce14d7010 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=7eb553e2debfd279d6b1b6fc95b90cdce14d7010 Author: Peter Christoffersen <gno...@pl...> Date: Tue Oct 13 16:01:26 2009 +0200 faad2: Don't leak element reference in the setcaps function Fixes bug #598139. --- ext/faad/gstfaad.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ext/faad/gstfaad.c b/ext/faad/gstfaad.c index 5ebb043..b9de36d 100644 --- a/ext/faad/gstfaad.c +++ b/ext/faad/gstfaad.c @@ -393,17 +393,20 @@ gst_faad_setcaps (GstPad * pad, GstCaps * caps) if (!faad->packetised) gst_faad_send_tags (faad); + gst_object_unref (faad); return TRUE; /* ERRORS */ wrong_length: { GST_DEBUG_OBJECT (faad, "codec_data less than 2 bytes long"); + gst_object_unref (faad); return FALSE; } init_failed: { GST_DEBUG_OBJECT (faad, "faacDecInit2() failed"); + gst_object_unref (faad); return FALSE; } } |