From: GStreamer (bugzilla.gnome.org) <bug...@bu...> - 2009-07-02 14:22:27
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=586891 GStreamer | gst-plugins-good | Ver: git ------- Comment #8 from Tim-Philipp Müller 2009-07-01 10:27 UTC ------- Created an attachment (id=137680) --> (http://bugzilla.gnome.org/attachment.cgi?id=137680&action=view) rewrite code for clarity I am not convinced the patch is correct. As I understand it, timescale is a *divisor*. The multiplication with the 'wrong' timescale (the presumed typo) should work out just fine (ie. like a division by the 'right' timescale values) when doing the durA/durB calculation later on, since (d1/ts1)/(d2/ts2) = (d1*ts2)/(d2*ts1). Bonus points for clarity this doesn't get of course. Attaching a hopefully clearer version of the code. I don't think it changes the logic though. If you could make your sample file available, that would be much appreciated. Edward suggested looking at the index and blacklisting streams with just one chunk instead of looking at the duration. Would that make things work with your file? -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=586891. |