[gst-cvs] gst-plugins-good: pulsesink: only notify if all checks passed

[<en...@ke...>]

Module: gst-plugins-good
Branch: master
Commit: 85ba1b3e6a7af72c74d1ed788bb9f9bf0537fabf
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=85ba1b3e6a7af72c74d1ed788bb9f9bf0537fabf

Author: Stefan Kost <en...@us...>
Date:   Thu Jun  4 17:37:03 2009 +0300

pulsesink: only notify if all checks passed

Replace goto done: with return, as those are checks when we don't want to flag a
pending notify.

---

 ext/pulse/pulsesink.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c
index 36d5b1b..fd349e7 100644
--- a/ext/pulse/pulsesink.c
+++ b/ext/pulse/pulsesink.c
@@ -315,20 +315,19 @@ gst_pulsering_context_subscribe_cb (pa_context * c,
 
   if (t != (PA_SUBSCRIPTION_EVENT_SINK_INPUT | PA_SUBSCRIPTION_EVENT_CHANGE) &&
       t != (PA_SUBSCRIPTION_EVENT_SINK_INPUT | PA_SUBSCRIPTION_EVENT_NEW))
-    goto done;
+    return;
 
   if (!pbuf->stream)
-    goto done;
+    return;
 
   if (idx != pa_stream_get_index (pbuf->stream))
-    goto done;
+    return;
 
   /* Actually this event is also triggered when other properties of
    * the stream change that are unrelated to the volume. However it is
    * probably cheaper to signal the change here and check for the
    * volume when the GObject property is read instead of querying it always. */
 
-done:
   /* inform streaming thread to notify */
   g_atomic_int_compare_and_exchange (&psink->notify, 0, 1);
 }