[gstreamer-bugs] [Bug 582942] crash in libvorbis when parsing some ogg files

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582942

  GStreamer | gst-plugins-base | Ver: 0.10.x




------- Comment #21 from Alex Bennee  2009-05-22 07:28 UTC -------
(In reply to comment #20)
> No, we're not misusing the API, it's just that the implementation is being
> stricter. Specifically, this was in this commit in libvorbis:
> 
> michael@songbird-desktop:~/src/xiph/vorbis/lib$ svn log -c 14811
> ------------------------------------------------------------------------
> r14811 | xiphmont | 2008-04-28 14:42:52 -0700 (Mon, 28 Apr 2008) | 4 lines
> 
> Additional bulletproofing to hufftree decoding; reject underpopulated 
> trees up-front.
> 
> 
> ------------------------------------------------------------------------
> 

I assume that the failure in vorbis_book_init_decode?

Does this mean the crash I'm seeing is just because I have a more upto date
libvorbis than previously?

It still doesn't change the fact that Gstremer needs to deal with it gracefully
rather than push on and let the codec crash. Or are you suggesting making the
vorbis codec itself more bullet proof?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582942.