From: <wt...@ke...> - 2008-03-24 11:24:30
|
CVS Root: /cvs/gstreamer Module: gst-plugins-base Changes by: wtay Date: Mon Mar 24 2008 11:24:36 UTC Log message: * gst-libs/gst/audio/gstaudiosink.c: (gst_audioringbuffer_release): Small debug improvement. * gst-libs/gst/audio/gstbaseaudiosink.c: (gst_base_audio_sink_render): Fix bug in determining the sample start/stop position, we want to base this decision on the fact that we are going forwards or backwards, not slower or faster. This fixes some ugly resync warnings when playing at very slow speeds. Modified files: . : ChangeLog gst-libs/gst/audio: gstaudiosink.c gstbaseaudiosink.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.3825&r2=1.3826 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstaudiosink.c.diff?r1=1.26&r2=1.27 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstbaseaudiosink.c.diff?r1=1.96&r2=1.97 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gst-plugins-base/ChangeLog,v retrieving revision 1.3825 retrieving revision 1.3826 diff -u -d -r1.3825 -r1.3826 --- ChangeLog 23 Mar 2008 13:41:27 -0000 1.3825 +++ ChangeLog 24 Mar 2008 11:24:21 -0000 1.3826 @@ -1,3 +1,15 @@ +2008-03-24 Wim Taymans <wim...@co...> + + * gst-libs/gst/audio/gstaudiosink.c: (gst_audioringbuffer_release): + Small debug improvement. + * gst-libs/gst/audio/gstbaseaudiosink.c: + (gst_base_audio_sink_render): + Fix bug in determining the sample start/stop position, we want to base + this decision on the fact that we are going forwards or backwards, not + slower or faster. This fixes some ugly resync warnings when playing at + very slow speeds. 2008-03-23 Sebastian Dröge <sl...@ci...> * ext/gio/gstgio.c: (gst_gio_get_supported_protocols): Index: gstaudiosink.c RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstaudiosink.c,v retrieving revision 1.26 retrieving revision 1.27 diff -u -d -r1.26 -r1.27 --- gstaudiosink.c 18 Dec 2007 15:56:51 -0000 1.26 +++ gstaudiosink.c 24 Mar 2008 11:24:22 -0000 1.27 @@ -422,6 +422,8 @@ if (!result) goto could_not_unprepare; + GST_DEBUG_OBJECT (sink, "unprepared"); return result; could_not_unprepare: Index: gstbaseaudiosink.c RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/audio/gstbaseaudiosink.c,v retrieving revision 1.96 retrieving revision 1.97 diff -u -d -r1.96 -r1.97 --- gstbaseaudiosink.c 22 Mar 2008 15:00:45 -0000 1.96 +++ gstbaseaudiosink.c 24 Mar 2008 11:24:22 -0000 1.97 @@ -1160,7 +1160,7 @@ /* positive playback rate, first sample is render_start, negative rate, first * sample is render_stop */ - if (bsink->segment.rate >= 1.0) + if (bsink->segment.rate >= 0.0) sample_offset = render_start; else sample_offset = render_stop; @@ -1211,7 +1211,7 @@ no_sync: /* we render the first or last sample first, depending on the rate */ |