From: GStreamer (bugzilla.gnome.org) <bug...@bu...> - 2006-05-15 16:30:51
|
Do not reply to this via email (we are currently unable to handle email responses and they get discarded). You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=3D338818 GStreamer | gst-plugins-good | Ver: HEAD CVS ------- Comment #7 from Andy Wingo 2006-05-15 16:30 UTC ------- Some new, non-comprehensive comments... My brain is not working right now= :/ * fine to keep the _calls files, use your best judgement :) * Check your copyrights -- the ones with your name should all be 2006 * header on gstv4l2object badly formatted -- just copy from gstv4l2.c * OPEN_V4L2OBJECT_PROPS/CLOSE_V4L2_PROPS nonstandard and mess with indentation; just define an enum in gstv4l2object.h or something: enum { PROP_0, PROP_DEVICE, PROP_DEVICE_NAME, PROP_FLAGS, PROP_STD, PROP_INPUT, PROP_FREQUENCY, PROP_V4L2_LAST =3D PROP_FREQUENCY }; and then in e.g. gstv4l2src.c: enum { PROP_FOO =3D PROP_V4L2_LAST + 1, ... }; * In general any of these magical macros should be made in such a way that you can add a semicolon at the end, so that gst-indent is happy. * functions that operate on GstV4l2Object should be called gst_v4l2_object_*. * you should comment a bit on the rationale for all of this macro trickery :) * any reason to have properyprobe in gstv4l2object and not in its own file? --=20 Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |