From: <tp...@ke...> - 2007-01-11 13:12:33
|
CVS Root: /cvs/gstreamer Module: gst-plugins-base Changes by: tpm Date: Thu Jan 11 2007 13:12:29 UTC Log message: * gst/playback/gstplaybin.c: (post_missing_element_message), (gen_video_element), (gen_text_element), (gen_audio_element), (gen_vis_element): Post missing-plugin messages also when we error out because converters, textoverlay or auto*sinks are missing (#161922). Modified files: . : ChangeLog gst/playback : gstplaybin.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.3079&r2=1.3080 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst/playback/gstplaybin.c.diff?r1=1.100&r2=1.101 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gst-plugins-base/ChangeLog,v retrieving revision 1.3079 retrieving revision 1.3080 diff -u -d -r1.3079 -r1.3080 --- ChangeLog 10 Jan 2007 16:08:18 -0000 1.3079 +++ ChangeLog 11 Jan 2007 13:12:17 -0000 1.3080 @@ -1,3 +1,11 @@ +2007-01-11 Tim-Philipp Müller <tim at centricular dot net> + + * gst/playback/gstplaybin.c: (post_missing_element_message), + (gen_video_element), (gen_text_element), (gen_audio_element), + (gen_vis_element): + Post missing-plugin messages also when we error out because + converters, textoverlay or auto*sinks are missing (#161922). 2007-01-10 Wim Taymans <wi...@fl...> * gst/playback/gstdecodebin.c: (dynamic_add), (close_pad_link), Index: gstplaybin.c RCS file: /cvs/gstreamer/gst-plugins-base/gst/playback/gstplaybin.c,v retrieving revision 1.100 retrieving revision 1.101 diff -u -d -r1.100 -r1.101 --- gstplaybin.c 9 Jan 2007 14:33:24 -0000 1.100 +++ gstplaybin.c 11 Jan 2007 13:12:17 -0000 1.101 @@ -795,6 +795,15 @@ } } +static void +post_missing_element_message (GstPlayBin * playbin, const gchar * name) +{ + GstMessage *msg; + msg = gst_missing_element_message_new (GST_ELEMENT_CAST (playbin), name); + gst_element_post_message (GST_ELEMENT_CAST (playbin), msg); +} /* make the element (bin) that contains the elements needed to perform * video display. We connect a handoff signal to identity so that we * can grab snapshots. Identity's sinkpad is ghosted to vbin. @@ -882,8 +891,7 @@ /* ERRORS */ no_sinks: { - /* FIXME: this warrants adding a CORE error category for missing - * elements/plugins */ + post_missing_element_message (play_bin, "autovideosink"); GST_ELEMENT_ERROR (play_bin, CORE, MISSING_PLUGIN, (_("Both autovideosink and xvimagesink elements are missing.")), (NULL)); @@ -891,6 +899,7 @@ no_colorspace: + post_missing_element_message (play_bin, "ffmpegcolorspace"); (_("Missing element '%s' - check your GStreamer installation."), "ffmpegcolorspace"), (NULL)); @@ -900,6 +909,7 @@ no_videoscale: + post_missing_element_message (play_bin, "videoscale"); "videoscale"), ("possibly a liboil version mismatch?")); @@ -987,6 +997,7 @@ no_overlay: + post_missing_element_message (play_bin, "textoverlay"); GST_WARNING_OBJECT (play_bin, "No overlay (pango) element, subtitles disabled"); return vbin; @@ -1076,12 +1087,14 @@ + post_missing_element_message (play_bin, "autoaudiosink"); (_("Both autoaudiosink and alsasink elements are missing.")), (NULL)); return NULL; no_audioconvert: + post_missing_element_message (play_bin, "audioconvert"); "audioconvert"), ("possibly a liboil version mismatch?")); @@ -1091,6 +1104,7 @@ no_audioresample: + post_missing_element_message (play_bin, "audioresample"); "audioresample"), ("possibly a liboil version mismatch?")); @@ -1207,6 +1221,7 @@ @@ -1215,6 +1230,7 @@ no_goom: + post_missing_element_message (play_bin, "goom"); "goom"), (NULL)); |