[gstreamer-bugs] [Bug 326875] GstQueue does not handle GST_FLOW_RESEND flow result

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=3D326875
 GStreamer | gstreamer (core) | Ver: 0.10.0





------- Comment #4 from Jan Schmidt  2006-02-13 12:59 UTC -------
It's sufficient to hold a reference to a buffer to ensure that noone else
modifies it - before an element modifies any buffer that it didn't create=
, the
element needs to check gst_buffer_is_writable, or call
gst_buffer_make_writable.

gst_buffer_is_writable is FALSE whenever the refcount is > 1 (or when the=
 data
pointer is read-only), ie when the caller isn't the sole owner of the buf=
fer
data.

So, either way, the unconditional buffer copy can and should be avoided.


--=20
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.