From: <tp...@ke...> - 2006-05-09 13:23:37
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Tue May 09 2006 13:23:18 UTC Log message: * tests/check/gst/gstbuffer.c: (GST_START_TEST): Add test case for flags + gst_buffer_make_metadata_writable(). Modified files: . : ChangeLog tests/check/gst : gstbuffer.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.2497&r2=1.2498 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/tests/check/gst/gstbuffer.c.diff?r1=1.11&r2=1.12 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.2497 retrieving revision 1.2498 diff -u -d -r1.2497 -r1.2498 --- ChangeLog 9 May 2006 12:01:32 -0000 1.2497 +++ ChangeLog 9 May 2006 13:23:06 -0000 1.2498 @@ -1,5 +1,10 @@ 2006-05-09 Tim-Philipp Müller <tim at centricular dot net> + * tests/check/gst/gstbuffer.c: (GST_START_TEST): + Add test case for flags + gst_buffer_make_metadata_writable(). + +2006-05-09 Tim-Philipp Müller <tim at centricular dot net> * gst/gstbuffer.c: (gst_buffer_make_metadata_writable): gst_buffer_make_metadata_writable() should maintain the buffer flags (those that make sense at least) (see #340859). Index: gstbuffer.c RCS file: /cvs/gstreamer/gstreamer/tests/check/gst/gstbuffer.c,v retrieving revision 1.11 retrieving revision 1.12 diff -u -d -r1.11 -r1.12 --- gstbuffer.c 17 Jan 2006 12:14:20 -0000 1.11 +++ gstbuffer.c 9 May 2006 13:23:06 -0000 1.12 @@ -273,6 +273,9 @@ GstBuffer *buffer, *sub1; buffer = gst_buffer_new_and_alloc (4); + GST_BUFFER_FLAG_SET (buffer, GST_BUFFER_FLAG_DISCONT); + GST_BUFFER_FLAG_SET (buffer, GST_BUFFER_FLAG_DELTA_UNIT); /* Buffer with refcount 1 should have writable metadata */ fail_unless (gst_buffer_is_metadata_writable (buffer) == TRUE); @@ -292,6 +295,17 @@ ASSERT_BUFFER_REFCOUNT (buffer, "buffer", 2); fail_unless (gst_buffer_is_metadata_writable (buffer) == FALSE); + /* Check that make_metadata_writable() maintains the buffer flags */ + fail_unless (GST_BUFFER_FLAG_IS_SET (sub1, GST_BUFFER_FLAG_DISCONT)); + fail_unless (GST_BUFFER_FLAG_IS_SET (sub1, GST_BUFFER_FLAG_DELTA_UNIT)); + /* Unset flags on writable buffer, then make sure they're still + * set on the original buffer */ + GST_BUFFER_FLAG_UNSET (sub1, GST_BUFFER_FLAG_DISCONT); + GST_BUFFER_FLAG_UNSET (sub1, GST_BUFFER_FLAG_DELTA_UNIT); + fail_unless (GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_DISCONT)); + fail_unless (GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_DELTA_UNIT)); /* Drop the subbuffer and check that the metadata is now writable again */ ASSERT_BUFFER_REFCOUNT (sub1, "sub1", 1); gst_buffer_unref (sub1); |