Menu
▾
▴
[gst-cvs] thomasvs common gstreamer: common/ gstreamer/ gstreamer/check/ gstreamer/check/gst/ gstreamer/gst/ gstreamer/gst/base/ gstreamer/gst/check/
|
From: <tho...@fr...> - 2005-08-21 15:01:32
|
CVS Root: /cvs/gstreamer
Modules: common gstreamer
Changes by: thomasvs
Date: Sun Aug 21 2005 08:01:30 PDT
Log message:
* check/Makefile.am:
clean up environment for when registry gets built versus
when actual tests are run; valgrind seems to not report
leaks if GST_PLUGIN_PATH is set to some specific values
* check/gst/gstbin.c: (GST_START_TEST):
add more refcounting checks; maybe this exposes a
preroll lock bug ?
* common/check.mak:
* gst/base/gstbasesink.c: (gst_base_sink_handle_object):
* gst/check/gstcheck.h:
* gst/gstbin.c: (bin_element_is_semi_sink), (gst_bin_get_state),
(gst_bin_change_state):
* gst/gstpad.c: (gst_pad_activate_push), (gst_pad_chain):
add/fix debugging/whitespace
Modified files:
common : check.mak
gstreamer : ChangeLog
gstreamer/check : Makefile.am
gstreamer/check/gst: gstbin.c
gstreamer/gst : gstbin.c gstpad.c
gstreamer/gst/base: gstbasesink.c
gstreamer/gst/check: gstcheck.h
Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/common/check.mak.diff?r1=1.5&r2=1.6
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1373&r2=1.1374
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/check/Makefile.am.diff?r1=1.44&r2=1.45
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/check/gst/gstbin.c.diff?r1=1.16&r2=1.17
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstbin.c.diff?r1=1.250&r2=1.251
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpad.c.diff?r1=1.425&r2=1.426
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/base/gstbasesink.c.diff?r1=1.42&r2=1.43
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/check/gstcheck.h.diff?r1=1.3&r2=1.4
====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v
retrieving revision 1.1373
retrieving revision 1.1374
diff -u -d -r1.1373 -r1.1374
--- ChangeLog 21 Aug 2005 11:40:44 -0000 1.1373
+++ ChangeLog 21 Aug 2005 15:01:16 -0000 1.1374
@@ -1,3 +1,20 @@
+2005-08-21 Thomas Vander Stichele <thomas at apestaart dot org>
+
+ * check/Makefile.am:
+ clean up environment for when registry gets built versus
+ when actual tests are run; valgrind seems to not report
+ leaks if GST_PLUGIN_PATH is set to some specific values
+ * check/gst/gstbin.c: (GST_START_TEST):
+ add more refcounting checks; maybe this exposes a
+ preroll lock bug ?
+ * common/check.mak:
+ * gst/base/gstbasesink.c: (gst_base_sink_handle_object):
+ * gst/check/gstcheck.h:
+ * gst/gstbin.c: (bin_element_is_semi_sink), (gst_bin_get_state),
+ (gst_bin_change_state):
+ * gst/gstpad.c: (gst_pad_activate_push), (gst_pad_chain):
+ add/fix debugging/whitespace
2005-08-21 Jan Schmidt <th...@ma...>
* check/gst/gstevent.c: (event_probe), (test_event),
Index: Makefile.am
RCS file: /cvs/gstreamer/gstreamer/check/Makefile.am,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -d -r1.44 -r1.45
--- Makefile.am 21 Aug 2005 11:15:57 -0000 1.44
+++ Makefile.am 21 Aug 2005 15:01:17 -0000 1.45
@@ -4,9 +4,14 @@
GST_TOOLS_DIR = $(top_builddir)/tools
-TESTS_ENVIRONMENT=\
+REGISTRY_ENVIRONMENT = \
GST_REGISTRY=$(CHECK_REGISTRY)
+TESTS_ENVIRONMENT = \
+ $(REGISTRY_ENVIRONMENT) \
+ GST_PLUGIN_PATH_ONLY=yes \
+ GST_PLUGIN_PATH=$(top_builddir)/gst
plugindir = $(libdir)/gstreamer-@GST_MAJORMINOR@
# rebuild gst-register-@GST_MAJORMINOR@ if needed
@@ -25,13 +30,9 @@
$(CHECK_REGISTRY):
$(TESTS_ENVIRONMENT) \
- GST_PLUGIN_PATH_ONLY=yes \
- GST_PLUGIN_PATH=$(top_builddir)/gst \
- $(top_builddir)/tools/gst-register
+ $(top_builddir)/tools/gst-register-@GST_MAJORMINOR@
-# FIXME: it'd be nicer to run the versioned register, but in that case
-# "make dist" complains about not finding gst-register-0.9.c
-TESTS = $(top_builddir)/tools/gst-register \
+check_PROGRAMS = \
gst/gst \
gst/gstbin \
gst/gstbuffer \
@@ -57,7 +58,8 @@
gst-libs/controller \
gst-libs/gdp
-check_PROGRAMS = $(TESTS)
+TESTS = $(top_builddir)/tools/gst-register-@GST_MAJORMINOR@ \
+ $(check_PROGRAMS)
noinst_HEADERS = gst/capslist.h
@@ -89,7 +91,7 @@
gst/gstminiobject \
gst/gstobject
-VALGRIND_TESTS_DISABLE = \
- $(top_builddir)/tools/gst-register \
- $(TESTS_THREADED) \
+VALGRIND_TESTS_DISABLE = \
+ $(top_builddir)/tools/gst-register-@GST_MAJORMINOR@ \
+ $(TESTS_THREADED) \
$(TESTS_TO_FIX)
Index: gstbin.c
RCS file: /cvs/gstreamer/gstreamer/check/gst/gstbin.c,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- gstbin.c 20 Aug 2005 12:14:27 -0000 1.16
+++ gstbin.c 21 Aug 2005 15:01:17 -0000 1.17
@@ -221,26 +221,72 @@
ASSERT_OBJECT_REFCOUNT (pipeline, "pipeline", 1);
ASSERT_OBJECT_REFCOUNT (src, "src", 1);
- ASSERT_OBJECT_REFCOUNT (src, "sink", 1);
+ ASSERT_OBJECT_REFCOUNT (sink, "sink", 1);
bus = GST_ELEMENT_BUS (pipeline);
- /* change state, spawning three times three messages */
+ /* change state to READY, spawning three messages */
+ GST_DEBUG ("setting pipeline to READY");
+ fail_unless (gst_element_set_state (GST_ELEMENT (pipeline), GST_STATE_READY)
+ == GST_STATE_SUCCESS);
+ /* each object is referenced by a message */
+ ASSERT_OBJECT_REFCOUNT (bus, "bus", 1);
+ ASSERT_OBJECT_REFCOUNT (src, "src", 2);
+ ASSERT_OBJECT_REFCOUNT (sink, "sink", 2);
+ ASSERT_OBJECT_REFCOUNT (pipeline, "pipeline", 2);
+ pop_messages (bus, 3);
+ fail_if ((gst_bus_pop (bus)) != NULL);
+ ASSERT_OBJECT_REFCOUNT (src, "src", 1);
+ ASSERT_OBJECT_REFCOUNT (pipeline, "pipeline", 1);
+ /* change state to PAUSED, spawning three messages */
+ GST_DEBUG ("setting pipeline to PAUSED");
+ fail_unless (gst_element_set_state (GST_ELEMENT (pipeline), GST_STATE_PAUSED)
+ /* each object is referenced by a message;
+ * base_sink_chain has taken a refcount on the sink, and is blocked on
+ * preroll */
+ ASSERT_OBJECT_REFCOUNT (sink, "sink", 3);
+ /* change state to PLAYING, spawning three messages */
GST_DEBUG ("setting pipeline to PLAYING");
fail_unless (gst_element_set_state (GST_ELEMENT (pipeline), GST_STATE_PLAYING)
== GST_STATE_SUCCESS);
- pop_messages (bus, 9);
+ /* each object is referenced by one message; sink still has an extra
+ * because it's still blocked on preroll */
- /* this test is completely bogus as the refcount can change while running */
-#if 0
ASSERT_OBJECT_REFCOUNT (bus, "bus", 1);
- ASSERT_OBJECT_REFCOUNT (sink, "sink", 1);
-#endif
/* go back to READY, spawning six messages */
+ /* FIXME: only now does the sink get unblocked from preroll
+ * (check log for "done preroll")
+ * mabe that's a bug ? */
GST_DEBUG ("setting pipeline to READY");
fail_unless (gst_element_set_state (GST_ELEMENT (pipeline), GST_STATE_READY)
@@ -251,6 +297,7 @@
ASSERT_OBJECT_REFCOUNT (pipeline, "pipeline", 3);
pop_messages (bus, 6);
ASSERT_OBJECT_REFCOUNT (sink, "sink", 1);
Index: check.mak
RCS file: /cvs/gstreamer/common/check.mak,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- check.mak 21 Aug 2005 11:31:40 -0000 1.5
+++ check.mak 21 Aug 2005 15:01:17 -0000 1.6
@@ -20,6 +20,7 @@
# valgrind any given test by running make test.valgrind
%.valgrind: % $(CHECK_REGISTRY)
$(REGISTRY_ENVIRONMENT) \
+ CK_DEFAULT_TIMEOUT=20 \
libtool --mode=execute \
$(VALGRIND_PATH) -q --suppressions=$(SUPPRESSIONS) \
--tool=memcheck --leak-check=yes --trace-children=yes \
RCS file: /cvs/gstreamer/gstreamer/gst/gstbin.c,v
retrieving revision 1.250
retrieving revision 1.251
diff -u -d -r1.250 -r1.251
--- gstbin.c 17 Aug 2005 16:33:26 -0000 1.250
+++ gstbin.c 21 Aug 2005 15:01:18 -0000 1.251
@@ -778,6 +778,7 @@
for (pads = child->srcpads; pads; pads = g_list_next (pads)) {
GstPad *peer;
+ GST_DEBUG ("looking at pad %p", pads->data);
if ((peer = gst_pad_get_peer (GST_PAD_CAST (pads->data)))) {
connected_src =
has_ancestor (GST_OBJECT_CAST (peer), GST_OBJECT_CAST (bin));
@@ -892,7 +893,7 @@
GstElement *child = GST_ELEMENT_CAST (children->data);
gst_object_ref (child);
- /* now we release the lock to enter a non blocking wait. We
+ /* now we release the lock to enter a non blocking wait. We
* release the lock anyway since we can. */
GST_UNLOCK (bin);
@@ -1152,7 +1153,7 @@
/* take base time */
base_time = element->base_time;
- /* make sure queues are empty, they could be filled when
+ /* make sure queues are empty, they could be filled when
* restarting. */
clear_queue (elem_queue, TRUE);
clear_queue (semi_queue, TRUE);
@@ -1160,6 +1161,7 @@
children = bin->children;
children_cookie = bin->children_cookie;
+ GST_DEBUG_OBJECT (bin, "reffing and examining children");
while (children) {
GstElement *child = GST_ELEMENT_CAST (children->data);
@@ -1183,7 +1185,9 @@
}
children = g_list_next (children);
}
+ GST_DEBUG_OBJECT (bin, "reffed and examined children");
GST_UNLOCK (bin);
/* after this point new elements can be added/removed from the
* bin. We operate on the snapshot taken above. Applications
* should serialize their add/remove and set_state. */
@@ -1203,6 +1207,7 @@
/* second step, change state of elements in the queue */
+ GST_DEBUG_OBJECT (bin, "change state of elements in the queue");
while (!g_queue_is_empty (elem_queue)) {
GstElement *qelement;
GList *pads;
Index: gstpad.c
RCS file: /cvs/gstreamer/gstreamer/gst/gstpad.c,v
retrieving revision 1.425
retrieving revision 1.426
diff -u -d -r1.425 -r1.426
--- gstpad.c 20 Aug 2005 20:15:53 -0000 1.425
+++ gstpad.c 21 Aug 2005 15:01:18 -0000 1.426
@@ -634,6 +634,8 @@
GstActivateMode old;
g_return_val_if_fail (GST_IS_PAD (pad), FALSE);
+ GST_CAT_DEBUG_OBJECT (GST_CAT_PADS, pad, "trying to set %s in push mode",
+ active ? "activated" : "deactivated");
GST_LOCK (pad);
old = GST_PAD_ACTIVATE_MODE (pad);
@@ -2928,7 +2930,7 @@
goto not_negotiated;
- /* NOTE: we read the chainfunc unlocked.
+ /* NOTE: we read the chainfunc unlocked.
* we cannot hold the lock for the pad so we might send
* the data to the wrong function. This is not really a
* problem since functions are assigned at creation time
@@ -2942,6 +2944,10 @@
ret = chainfunc (pad, buffer);
+ GST_CAT_LOG_OBJECT (GST_CAT_SCHEDULING, pad,
+ "called chainfunction &%s of pad %s:%s, returned %d",
+ GST_DEBUG_FUNCPTR_NAME (chainfunc), GST_DEBUG_PAD_NAME (pad), ret);
GST_STREAM_UNLOCK (pad);
return ret;
Index: gstbasesink.c
RCS file: /cvs/gstreamer/gstreamer/gst/base/gstbasesink.c,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -d -r1.42 -r1.43
--- gstbasesink.c 18 Aug 2005 16:20:24 -0000 1.42
+++ gstbasesink.c 21 Aug 2005 15:01:18 -0000 1.43
@@ -1,7 +1,7 @@
/* GStreamer
* Copyright (C) 2005 Wim Taymans <wi...@fl...>
*
- * gstbasesink.c:
+ * gstbasesink.c:
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -473,7 +473,7 @@
GST_PREROLL_LOCK (pad);
/* push object on the queue */
- GST_DEBUG ("push on queue %p", basesink, obj);
+ GST_DEBUG_OBJECT (basesink, "push %p on preroll_queue", obj);
g_queue_push_tail (basesink->preroll_queue, obj);
have_event = GST_IS_EVENT (obj);
@@ -572,7 +572,7 @@
/* now we commit our state */
GST_STATE_LOCK (basesink);
- GST_DEBUG ("commit state %p >", basesink);
+ GST_DEBUG_OBJECT (basesink, "commit state");
gst_element_commit_state (GST_ELEMENT (basesink));
GST_STATE_UNLOCK (basesink);
@@ -604,10 +604,10 @@
* application thread and we don't want to block there. */
if (length > basesink->preroll_queue_max_len && !have_event) {
/* block until the state changes, or we get a flush, or something */
- GST_DEBUG ("element %s waiting to finish preroll",
+ GST_DEBUG_OBJECT (basesink, "waiting to finish preroll",
GST_ELEMENT_NAME (basesink));
GST_PREROLL_WAIT (pad);
- GST_DEBUG ("done preroll");
+ GST_DEBUG_OBJECT (basesink, "done preroll");
if (G_UNLIKELY (GST_PAD_IS_FLUSHING (pad)))
@@ -651,7 +651,7 @@
g_warning ("STREAM_LOCK should have been locked !!");
if (t > 0)
@@ -686,7 +686,7 @@
/* now we abort our state */
- GST_DEBUG ("abort state %p >", basesink);
+ GST_DEBUG_OBJECT (basesink, "abort state");
gst_element_abort_state (GST_ELEMENT (basesink));
@@ -983,7 +983,7 @@
return result;
}
-/* FIXME, not all sinks can operate in pull mode
+/* FIXME, not all sinks can operate in pull mode
*/
static void
gst_base_sink_loop (GstPad * pad)
Index: gstcheck.h
RCS file: /cvs/gstreamer/gstreamer/gst/check/gstcheck.h,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- gstcheck.h 21 Aug 2005 10:39:39 -0000 1.3
+++ gstcheck.h 21 Aug 2005 15:01:18 -0000 1.4
@@ -203,7 +203,8 @@
int rc; \
rc = GST_OBJECT_REFCOUNT_VALUE (object); \
fail_unless (rc == value, \
- "%s refcount is %d instead of %d", name, rc, value); \
+ "%s (%p) refcount is %d instead of %d", \
+ name, object, rc, value); \
} G_STMT_END
#define ASSERT_CAPS_REFCOUNT(caps, name, value) \
|