[gst-cvs] ds gst-plugins: gst-plugins/ gst-plugins/gst/mpegaudioparse/

[David S. <ds...@pd...>]

CVS Root:       /home/cvs/gstreamer
Module:         gst-plugins
Changes by:     ds
Date:           Thu Feb 05 2004  14:25:10 PST

Log message:
* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain):
Unref leaked buffer.  (Noticed by Ronald)

Modified files:
    .               : ChangeLog
    gst/mpegaudioparse: gstmpegaudioparse.c

Links:
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/ChangeLog.diff?r1=1.280&r2=1.281
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.35&r2=1.36

====Begin Diffs====
Index: ChangeLog
===================================================================
RCS file: /home/cvs/gstreamer/gst-plugins/ChangeLog,v
retrieving revision 1.280
retrieving revision 1.281
diff -u -d -r1.280 -r1.281
--- ChangeLog	5 Feb 2004 17:09:36 -0000	1.280
+++ ChangeLog	5 Feb 2004 22:24:58 -0000	1.281
@@ -1,3 +1,8 @@
+2004-02-05  David Schleef  <ds...@sc...>
+
+	* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain):
+	Unref leaked buffer.  (Noticed by Ronald)
+
 2004-02-05  David I. Lehn  <dl...@us...>
 
 	* pkgconfig/gstreamer-libs-uninstalled.pc.in:
Index: gstmpegaudioparse.c
===================================================================
RCS file: /home/cvs/gstreamer/gst-plugins/gst/mpegaudioparse/gstmpegaudioparse.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- gstmpegaudioparse.c	30 Jan 2004 14:23:18 -0000	1.35
+++ gstmpegaudioparse.c	5 Feb 2004 22:24:58 -0000	1.36
@@ -316,10 +316,13 @@
 
   /* if we have something left from the previous frame */
   if (mp3parse->partialbuf) {
+    GstBuffer *newbuf;
 
-    mp3parse->partialbuf = gst_buffer_merge(mp3parse->partialbuf, buf);
+    newbuf = gst_buffer_merge(mp3parse->partialbuf, buf);
     /* and the one we received.. */
     gst_buffer_unref(buf);
+    gst_buffer_unref(mp3parse->partialbuf);
+    mp3parse->partialbuf = newbuf;
   }
   else {
     mp3parse->partialbuf = buf;