Menu

#33 Build fix for older version of Visual Studio

Unstable_(example)
closed-fixed
None
5
2014-08-03
2014-06-22
No

This patch fixes the build of VS2008.

1 Attachments

Discussion

  • Bob Friesenhahn

    Bob Friesenhahn - 2014-06-22
    • assigned_to: Bob Friesenhahn
     
  • Bob Friesenhahn

    Bob Friesenhahn - 2014-06-22

    I appreciate all this good work, which benefits both projects. Something which is pending with VisualMagick configure (and hindering the next GraphicsMagick release) is that Visual Studio 2008 (and many other versions) do not handle the case where two files in a project have the same base name. In Visual Studio .net (and later) it is possible to specify the output file name. In Visual C++ 6.0 it is only possible to set the output directory (which can be done on a per-file level).

    This problem is blocking me from including proper Google WebP support in the Visual Studio build. There have also been issues with libxml2 and FreeType which were fixed using trivial approaches (e.g. rename source file). I am able to build GraphicsMagick with WebP under Visual Studio if I spend a few minutes specifying output file names in the project.

    It would be good to have a way to specify a desired level of disambiguation (include partial directory part in output file name) or even automatically detect when there is a conflict and supply the necessary level of disambiguation in the the output file names so that there is no conflict and it is clear which objects are associated with a given source file.

    Since you are obviously much more adept than I am at working on VisualMagick configure code, might you be willing to take on this challenge as well?

     
  • Dirk Lemstra

    Dirk Lemstra - 2014-06-22

    That has been fixed in IM already. It detects duplicate output names and renames the output file. I can post the patch later this week.

     
  • Dirk Lemstra

    Dirk Lemstra - 2014-06-27

    Can you apply my other patches to configure.exe first? It is then easier for me to create a patch for the duplicate file names.

     
  • Bob Friesenhahn

    Bob Friesenhahn - 2014-06-30

    I have not gotten to your patches yet. I will apply them and test when I find the time.

     
  • Dirk Lemstra

    Dirk Lemstra - 2014-07-01

    Okay, I will wait for that.

     
  • Bob Friesenhahn

    Bob Friesenhahn - 2014-08-03

    Applied.

     
  • Bob Friesenhahn

    Bob Friesenhahn - 2014-08-03
    • status: open --> closed-fixed
     

Log in to post a comment.