From: Don A. <dal...@us...> - 2002-04-16 04:29:37
|
On Mon, 2002-04-15 at 21:03, Jeffrey C. Ollie wrote: > On Mon, Apr 15, 2002 at 09:26:57PM +0200, Bernd Schandl wrote: > > > > Should this really be a translatable string? > > > > #: GenericFilter.py:763 > > msgid "class" > > msgstr "" > > No, if you look at the code that is referenced here is that we are > trying to translate the results of looking up the key 'class' in a > dictionary. It looks to me like the tool that is generating the > template.po is getting too aggressive. > > name = _(attrs['class']) > This translation won't work. Class won't get translated, the runtime value of attrs['class'] will. > But anyway, I'd like to redesign the XML that filters are stored with anyway, > so that you could have a file that looked something like this: > > <?xml version="1.0" encoding="iso-8859-1"?> > <filters> > <filter> > <name lang="en_US">Roquefort</name> > <name lang="fr_FR">Roquefort</name> > <comment lang="en_US">Cheese</comment> > <comment lang="fr_FR">Fromage</comment> > <and> > <rule class="Has a name"> > <arg value=""/> > <arg value="Roquefort"/> > <arg value=""/> > <arg value=""/> > </rule> > </and> > </filter> > </filters> > > I think that something like this will be needed for when I put > together a set of system filters, but this may make life harder for > translators as they'll have to look multiple places to make > translations. But I can't think of a better way to do it using the > standard gettext methods. I'm not particularly fond of making the translators go through multiple files. Their job is hard enough as it is. Don -- Don Allingham dal...@us... http://gramps.sourceforge.net |