Re: [Gramps-devel] #7362 #8103: Patch for wrapping some labels into filtersidebar

[Jerome <rom...@ya...>]

 From locations where we could wrap strings*,
sidebarfilter is the main one who clearly uses BasicLabel widget!

Workaround ('\n') - close to option2 - made into the french 
translation*, is on:

#: ../gramps/gui/editors/filtereditor.py:596
#: ../gramps/gui/filters/sidebar/_citationsidebarfilter.py:79
#: ../gramps/gui/filters/sidebar/_eventsidebarfilter.py:76
#: ../gramps/gui/filters/sidebar/_familysidebarfilter.py:88
#: ../gramps/gui/filters/sidebar/_mediasidebarfilter.py:67
#: ../gramps/gui/filters/sidebar/_notesidebarfilter.py:72
#: ../gramps/gui/filters/sidebar/_personsidebarfilter.py:93
#: ../gramps/gui/filters/sidebar/_placesidebarfilter.py:74
#: ../gramps/gui/filters/sidebar/_reposidebarfilter.py:75
#: ../gramps/gui/filters/sidebar/_sourcesidebarfilter.py:66
#: ../gramps/plugins/lib/libhtmlconst.py:116
#: ../gramps/gen/display/name.py:363
#: ../gramps/gen/display/name.py:632
#: ../gramps/gen/display/name.py:726
#: ../gramps/gen/utils/keyword.py:62
#: ../gramps/gen/utils/keyword.py:63
#: ../gramps/gen/utils/keyword.py:64
#: ../gramps/gen/utils/keyword.py:67
#: ../gramps/gen/utils/keyword.py:70

//ref lines from master//


As option1 does not break current translation strings and wrap strings 
if only they need it. I find option1 the proper solution.


Jérôme

Le ven. 17 oct. 2014 at 10:52, Jerome <rom...@ya...> a écrit :
> Yes, option1 is more elegant. +1
> Does it still work if we set "wrap=False" everywhere?
> 
> Workaround like option2 is sometimes used on translations (eg. the 
> french one!).
> 
> In relation with your comments[1][2] on bug #7362, I listed some 
> locations[3], where we could wrap text, if need. 
> 
> * entries for licence on webreports (drop down list)
> * custom name formats ('Preferences' dialog)
> * 'About' dialog
> * filter gramplet into sidebar
> 
> All of them can increase size (width) of parent dialog or space.
> 
> 
> 
> [1] https://gramps-project.org/bugs/view.php?id=7362#c34438
> [2] https://gramps-project.org/bugs/view.php?id=7362#c34478
> [3] https://gramps-project.org/bugs/view.php?id=7116#c31941
> 
> 
> Thanks!
> J.
> 
> Le ven. 17 oct. 2014 at 0:24, Nick Hall <ni...@gr...> a 
> écrit :
>>  On 16/10/14 19:07, Jerome wrote:
>>>  I want to propose one patch for adding an alternate BasicLabel() 
>>>  widget, which is used on filtersidebar. # was only for citation 
>>>  sidebarfilter
>>>  
>>>  It sounds a simple cosmetic visual issue, but it leads to width 
>>>  expansion.
>>>  An annoying issue in relation with the workspace. No one likes to 
>>>  always resize the sidebar.
>>>  
>>>  Also, this alternate widget might be used on others parts of the 
>>>  code.
>>>  
>>>  Bonus, it looks also good for large translated strings.
>>>  
>>>  So, why to ask?
>>>  
>>>  Because wrapping label (if need) is something not common into 
>>> Gramps.
>>>  
>>>  What do you think?
>>>  
>>>  Attached possible patch.
>>>  
>>> 
>>  I think that I would just add an extra "wrap" parameter to the 
>>  existing BasicLabel widget.  See the attached option 1 patch.
>>  
>>  The alternative is to add line breaks in the labels of the citation 
>>  filter gramplet.  See the attached option 2 patch.
>>  
>>  Option 1 keeps the labels short.  For example, "Custom filter" is 
>>  split onto two lines.
>>  
>>  Nick.
>>  
>> ------------------------------------------------------------------------------
>>  Comprehensive Server Monitoring with Site24x7.
>>  Monitor 10 servers for $9/Month.
>>  Get alerted through email, SMS, voice calls or mobile push 
>>  notifications.
>>  Take corrective actions from your mobile device.
>>  http://p.sf.net/sfu/Zoho
>>  _______________________________________________
>>  Gramps-devel mailing list
>>  Gra...@li...
>>  https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>  
>>  
>> 
> 
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push 
> notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>