From: Vassilii K. <vas...@ta...> - 2013-10-01 08:42:35
|
I've also removed the SDN version reporting you forgot to remove, that was supposed to guard against the scenario described by Tim. On 30.09.2013 20:46, Nick Hall wrote: > I agree, so I have committed a fix for our code and removed the sdn import. > > Both hebrew date functions have been tested from the earliest valid date > to the year 2500. We now get the same results as the sdn calendar module. > > Nick. > > > On 29/09/13 22:44, Tim Lyons wrote: >> Optionally importing it seems a terrible idea, if only because if anyone >> reports a bug, there will be ambiguity as to which package they actually got >> to use. >> >> At least if we rely on our own package we are in charge of our destiny. >> >> Tim. >> |