Re: [Gramps-devel] Question about changing ErrorDialog code

[Nick H. <nic...@ho...>]

Tim,

I'm not sure that this is a good idea in gramps34 or gramps40.

You would have to check every call to ErrorDialog and escape any 
character that would be wrongly interpreted as markup.  In particular, 
the ErrorDialog is used to display the error message from exceptions.

Nick.


On 10/05/13 11:56, Tim Lyons wrote:
> (1)  In gramps34/src/QuestionDialog.py, WarningDialog calls
> self.format_secondary_markup(msg2).
>
> However, ErrorDialog calls self.format_secondary_text(msg2). This
> means that if there is any markup including hyperlinks in the
> secondary message it will be correctly rendered in WarningDialog but
> not in ErrorDialog.
>
> Would there be any objection to my changing ErrorDailog to call
> self.format_secondary_markup(msg2)?
>
> (The same thing will apply to dialog.py in gramps40 and trunk)
>
>
> Regards,
> Tim.
>
>
>
> Also,
> (2) This is platform dependent! In QuestionDialog.py, I have had to
> change QuestionDialog2 to connect the 'activate-link' signal to a
> method to display a url, otherwise the url appears correctly in the
> dialog, but clicking it in some platforms does nothing (see https://github.com/emesene/emesene/issues/723)
> . However, I don't know how to make the same change for the classes
> that are derived from gtk.MessageDialog - does anybody know how to do
> this?
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>