Re: [Gramps-devel] Handling Addons [was prepare gramps 3.4]

[Doug B. <dou...@gm...>]

On Thu, May 10, 2012 at 6:28 AM, Jérôme <rom...@ya...> wrote:
> Doug,
>
>
>> Ok, but let's not leave it like this... this is a hack that we should
>> fix with a solution that will work for future variations.
>
>
> It should be nicer/proper after rev1273[1].

Yes, that is better! But we should not check the addon name, but to
see if there is a "setup.py" in the addon directory. I can help this
weekend if you get stuck on that... it should be easy, something like:

if os.path.exists("%s/setup.py" % path_to_addon):
  ... system("cd ...")

(there is a isfile() somewhere which is better for this use)

This would be instead of checking for "lxml" specifically. Then,
anyone can put additional build code in setup.py.

Thanks!

-Doug

> Thank you!
>
>
>>  That is one sophisticated setup.py file! Glad you got it to work.
>
>
> It is a part of 'make.py' derived from my first experimentations on
> 'po/update_po.py' (trunk)[2], which has been inherited from  and is related
> to 'po/check_po'[3]!
> Powered by python, gettext and Gnu tools. :)
>
> I am not certain to provide paths for windows platform is very useful, it is
> just more accessible than 'make.py'!
>
> Some few minor issues are remaining (ie. do not need to call 'mkdir -p
> locale' every time!).
>
> Anyway, it also adds a new feature against current make.py: the quicker
> ability to update/create all locales according existing translations (gramps
> program) with one argument (it is also for only one addon = more easy!)...
>
>
> [1]
> http://gramps-addons.svn.sourceforge.net/viewvc/gramps-addons?revision=1273&view=revision
> [2] http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/po/update_po.py
> [3] http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/po/check_po
>
>
>
> Jérôme
>
>
> Doug Blank a écrit :
>>
>> On Wed, May 9, 2012 at 1:10 PM, Jérôme <rom...@ya...> wrote:
>>
>>> Doug,
>>>
>>>> your latest commit says that "lxml addon needs some
>>>> non-python and non-xml files: css, xsl, dtd, rng; need to find a way
>>>> via make.py". But as long as you create (and add to svn) the necessary
>>>> files in po and locale, you can do that in contrib/lxml through
>>>> whatever mechanism you want (Makefile, setup.py, etc).
>>>> ..
>>>>
>>>> 2) When you "build all" (or "build AddonName") it doesn't know any
>>>> specifics (eg, such as that outlined above)
>>>> ..
>>>>
>>>> (2) could be fixed by looking for, and calling, a
>>>> default addon-specific build command (for example, looking for a
>>>> "AddonName/Makefile" or "AddonName/setup.py" or "AddonName/Manifest").
>>>> Currently when you "build all" or "build lxml" it will not build all
>>>> that needs building, nor include all of the relevant files (right?).
>>>
>>>
>>> 'lxml' gramplet is ignored by listing.
>>>
>>> So, I only made a minor change on rev1262 [1]:
>>>
>>> 1. 'python make.py build all' command:
>>> To continue when addon is matching 'lxml'!
>>> Compilation for translations on lxml addon is not a problem.
>>>
>>> 2. I have generated a custom 'lxml/setup.py' (just 'setup' as name, not
>>> related to distutils or others builders!) for 'lxml' addon. I tried to
>>> keep
>>> 'make.py' logic, some refactoring (only one addon!) and I let the kwargs
>>> stuff alone (too complicated for me).
>>>
>>> True, I suppose it is also possible to call "python lxml/setup.py -b"
>>> instead of ignoring this addon into 'python make.py build lxml' /or build
>>> all/ commands.
>>
>>
>> Ok, but let's not leave it like this... this is a hack that we should
>> fix with a solution that will work for future variations.
>>
>> Can you change it so that:
>>
>> if there is a */setup.py file (like you have) then we call it (we can
>> just os.system("cd Addon; python setup.py") to keep it simple. Your
>> setup.py can check timestamps to see if there is anything to do, like
>> Makefile). Otherwise, we do what we would do normally.
>>
>> That is one sophisticated setup.py file! Glad you got it to work.
>>
>> -Doug
>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> _______________________________________________
>>>>>
>>>>> Gramps-devel mailing list
>>>>> Gra...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>>
>>>>
>>
>