From: Michiel N. <m.d...@he...> - 2011-08-27 09:20:31
|
Hi, That looks like an ordinary list comprehension. Nothing wrong with that. Just change it to: if n and n.get_type() == gen.lib.NoteType.SOURCE_TEXT And why not run the check and repair tool before the export, because there seems to be a note handle in a list that refers to a note that is not in the database. Michiel On 08/27/2011 08:49 AM, jerome wrote: > Otherwise, does someone can also explain or review this code: > > if len(ref.get_note_list())> 0: > > note_list = [ self.dbase.get_note_from_handle(h) > for h in ref.get_note_list() ] > note_list = [ n for n in note_list > if n.get_type() == gen.lib.NoteType.SOURCE_TEXT] > > I suppose there is a typo 'n for n in note_list' because I cannot see where this 'n' is set ! Is it 'n = len(ref.get_note_list())' then handle on note_list ??? This sounds strange and returns an error if n is None... > > I added the bug report to the '3.3.1' roadmap too. > http://www.gramps-project.org/bugs/view.php?id=5184 > > > Jérôme > > --- En date de : Ven 26.8.11, Nick Hall<nic...@ho...> a écrit : > >> De: Nick Hall<nic...@ho...> >> Objet: Re: [Gramps-devel] possible 3.3.1 release name >> À: gra...@li... >> Date: Vendredi 26 août 2011, 0h02 >> Jérôme, >> >> Thanks. I have had a look at these. >> >> #5108 is now fixed. >> I'm not sure what we want to do with #5077 and have asked >> for feedback. >> >> Whilst looking at #5144 I noticed that sorting of names >> only works for >> the "Surname, Firstname, Suffix" format. We need to >> improve the >> sort_string method to cope with different name >> formats. We also need to >> make the sorting of names consistent between the Person and >> Family views. >> >> Nick. >> >> >> On 25/08/11 09:35, jerome wrote: >>> Note, what about the roadmap ? >>> http://www.gramps-project.org/bugs/roadmap_page.php?version_id=27 >>> >>> I suppose some bug reports could move to 3.3.2 roadmap >> ... but if someone has an idea for fixing: >>> >>> * a gramplet/grampsbar/relationship view issue >>> http://www.gramps-project.org/bugs/view.php?id=5108 >>> http://www.gramps-project.org/bugs/view.php?id=5077 >>> >>> * ordering surname on embeddedlist (editor(s)...) >>> http://www.gramps-project.org/bugs/view.php?id=5112 >>> >>> * "latin" surname guessing: >>> http://www.gramps-project.org/bugs/view.php?id=5151#c20723 >>> >>> * //review for a patch// "sort family list on father >> or mother name" >>> http://www.gramps-project.org/bugs/view.php?id=5144 >>> >>> this might be great. >>> >>> >>> Regards, >>> Jérôme >>> >>> >>> --- En date de : Mer 24.8.11, Stéphane Charette<ste...@gm...> >> a écrit : >>> >>> De: Stéphane Charette<ste...@gm...> >>> Objet: Re: [Gramps-devel] possible 3.3.1 release name >>> À: gra...@li... >>> Date: Mercredi 24 août 2011, 22h49 >>> >>> On Wed, Aug 24, 2011 at 13:40, Duncan Lithgow<dun...@gm...> >> wrote: >>> >>>> 2011/8/22 Paul Franklin<pf....@gm...> >>>>> I would like to suggest that thought be given >> to naming >>>>> 3.3.1 the "tenth anniversary edition" in honor >> of Don and >>>>> all the early gramps developers. >>> >>> >>> +1 >>> >>> >>> >>> >>> So...what name? >>> >>> >>> >>> Stéphane >>> >>> >>> >>> -----La pièce jointe associée suit----- >>> >>> >> ------------------------------------------------------------------------------ >>> EMC VNX: the world's simplest storage, starting under >> $10K >>> The only unified storage solution that offers unified >> management >>> Up to 160% more powerful than alternatives and 25% >> more efficient. >>> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev >>> -----La pièce jointe associée suit----- >>> >>> _______________________________________________ >>> Gramps-devel mailing list >>> Gra...@li... >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel >>> >>> >>> >> ------------------------------------------------------------------------------ >>> EMC VNX: the world's simplest storage, starting under >> $10K >>> The only unified storage solution that offers unified >> management >>> Up to 160% more powerful than alternatives and 25% >> more efficient. >>> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev >>> _______________________________________________ >>> Gramps-devel mailing list >>> Gra...@li... >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel >>> >>> >> >> ------------------------------------------------------------------------------ >> EMC VNX: the world's simplest storage, starting under $10K >> The only unified storage solution that offers unified >> management >> Up to 160% more powerful than alternatives and 25% more >> efficient. >> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> https://lists.sourceforge.net/lists/listinfo/gramps-devel >> > > ------------------------------------------------------------------------------ > EMC VNX: the world's simplest storage, starting under $10K > The only unified storage solution that offers unified management > Up to 160% more powerful than alternatives and 25% more efficient. > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |