Re: [Gramps-devel] escaping certain characters

[Benny M. <ben...@gm...>]

Don't forget src/lib/libhtmlbackend.py which writes to html for all text
reports.

Benny


2011/2/18 Gerald Britton <ger...@gm...>

> OK -- I committed revision 16664,  which is a two-line change:
>
> --- src/plugins/webreport/NarrativeWeb.py       (revision 16663)
> +++ src/plugins/webreport/NarrativeWeb.py       (working copy)
> @@ -210,7 +210,8 @@
>
>  # This command then defines the 'html_escape' option for escaping
>  # special characters for presentation in HTML based on the above list.
> -def html_escape(text):
> +from xml.sax.saxutils import escape as html_escape
> +def _html_escape(text):
>     """Convert the text and replace some characters with a &# variant."""
>
>     # First single characters, no quotes
>
> It just replaces html_escape with xml.sax.saxutils.escape as
> discussed.  My testing turned up no anomalies but it needs to be
> exercised on a wide variety of data before declaring it good.  Hence
> the commit.
>
> If it causes incorrect output, please post it here and know that you
> can undo the commit by removing the leading "_" from "def
> _html_escape".
>
>
>
> On Fri, Feb 18, 2011 at 4:26 AM, Benny Malengier
> <ben...@gm...> wrote:
> >
> >
> > 2011/2/18 Benny Malengier <ben...@gm...>
> >>
> >>
> >> 2011/2/17 Gerald Britton <ger...@gm...>
> >>>
> >>> I'd like to suggest that we ditch our home-grown escape function and
> >>> use the library one unless there is something ours does that the
> >>> standard one doesn't, in which case I think we should wrap the
> >>> standard one to add our unique additional functionality.
> >>
> >> For me this is ok. Personally I think the xml.sax.saxutils thing does
> the
> >> same and is also official part of python
> >>
> http://docs.python.org/library/xml.sax.utils.html#module-xml.sax.saxutils
> >>
> >
> > With this I mean that I wonder if it is still needed today to escape
> things
> > like accented words in html. Just the control characters as we do now
> seems
> > ok.
> >
> > Benny
> >
> >>
> >> Benny
> >>
> >>>
> >>> On Thu, Feb 17, 2011 at 4:11 AM, Benny Malengier
> >>> <ben...@gm...> wrote:
> >>> >
> >>> >
> >>> > 2011/2/17 Rob Healey <rob...@gm...>
> >>> >>
> >>> >> Greetings All:
> >>> >>
> >>> >> I just committed a change to src/plugins/lib/libhtml.py to
> html_escape
> >>> >> from NarrativeWeb to it!
> >>> >>
> >>> >> Please do svn up, and now I need some help with something please!
> >>> >>
> >>> >> I have a string such as: 38° 38′ 03″ N
> >>> >> or as: 82° 41′ 29″ W
> >>> >>
> >>> >> They need to be like:
> >>> >> 38 38 03 N
> >>> >> 82 41 29 W before I can process them....
> >>> >
> >>> > No,
> >>> >
> >>> > You may _not_ change the escape function like that. This is not
> general
> >>> > behavior, nor does what the escape function is for.
> >>> > So, create your own function for that, don't change any existing
> >>> > functions.
> >>> >
> >>> > Benny
> >>> >>
> >>> >> I need to escape the symbols before I convert it to a decimal...
> >>> >>
> >>> >> Can you show me or tell me how to modify html_escape in libhtml.py ?
> >>> >>
> >>> >> Sincerely yours,
> >>> >> Rob G. Healey
> >>> >>
> >>> >>
> >>> >>
> >>> >>
> >>> >>
> ------------------------------------------------------------------------------
> >>> >> The ultimate all-in-one performance toolkit: Intel(R) Parallel
> Studio
> >>> >> XE:
> >>> >> Pinpoint memory and threading errors before they happen.
> >>> >> Find and fix more than 250 security defects in the development
> cycle.
> >>> >> Locate bottlenecks in serial and parallel code that limit
> performance.
> >>> >> http://p.sf.net/sfu/intel-dev2devfeb
> >>> >> _______________________________________________
> >>> >> Gramps-devel mailing list
> >>> >> Gra...@li...
> >>> >> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>> >>
> >>> >
> >>> >
> >>> >
> >>> >
> ------------------------------------------------------------------------------
> >>> > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio
> >>> > XE:
> >>> > Pinpoint memory and threading errors before they happen.
> >>> > Find and fix more than 250 security defects in the development cycle.
> >>> > Locate bottlenecks in serial and parallel code that limit
> performance.
> >>> > http://p.sf.net/sfu/intel-dev2devfeb
> >>> > _______________________________________________
> >>> > Gramps-devel mailing list
> >>> > Gra...@li...
> >>> > https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>> >
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Gerald Britton
> >>
> >
> >
>
>
>
> --
> Gerald Britton
>