Re: [Gramps-devel] Commit 15388 - extra space in descendant report

[Nick H. <nic...@ho...>]

Doug Blank wrote:
> On Thu, May 13, 2010 at 1:30 PM, Nick Hall <nic...@ho...> wrote:
>   
>> Doug Blank wrote:
>>     
>>> On Thu, May 13, 2010 at 11:30 AM, Nick Hall <nic...@ho...>
>>> wrote:
>>>
>>>       
>>>> I notice that this commit adds a space after the generation numbers in
>>>> the descendant report.
>>>>
>>>> The generation numbers are displayed as paragraph leader text.  In all
>>>> other document generators, apart from the ascii docgen, spacing is added
>>>> to the leader in the generator.  For example the html docgen adds a
>>>> single space;  the odf docgen adds a tab.
>>>>
>>>> If we add a space in the report, then the html output will contain two
>>>> spaces between the descendant number and the text and the ascii output
>>>> will only contain one space.  I know that this is only a minor point but
>>>> I think it would be better to add the space in the ascii docgen plugin
>>>> (a one line change).
>>>>
>>>> Does anyone who is familiar with this code have any views?
>>>>
>>>>         
>>> Nick,
>>>
>>> I looked at the ASCII docgen, and was going to do as you say, but I
>>> didn't get it figured out.
>>>
>>> I'd say "+1" with removing the space in the report and adding it on the
>>> backend.
>>>
>>> -Doug
>>>
>>>
>>>       
>> Doug,
>>
>> I have done this in trunk (r15404).
>>
>> I would normally regard this as a bug fix and also commit it to gramps32,
>> but we have a code freeze at the moment.  Should I wait until after the next
>> release and then commit it to gramps32, or is the fix so small that I can
>> commit it now?
>>     
>
> Channelling Benny: if you feel like each particular change has made
> stable more stable, then add it. If you aren't 100% sure, and feel it
> needs more testing, make sure you give it some time before it goes to
> the presses. (I looked over
> http://gramps.svn.sourceforge.net/viewvc/gramps?view=rev&revision=15404
> and I don't see anything that could go wrong.)
>
> -Doug
>
>   

Since it was a single line fix that nothing should go wrong with, I have 
committed it (r15408).

I also created a bug for it (3970) and added it to the roadmap.

Nick.

>> Nick.
>>
>>     
>>>> Regards,
>>>>
>>>> Nick.
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>>
>>>> _______________________________________________
>>>> Gramps-devel mailing list
>>>> Gra...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>
>>>>
>>>>         
>>>
>>>       
>
>
>