From: Doug B. <dou...@gm...> - 2010-01-10 01:24:58
|
On Sat, Jan 9, 2010 at 7:33 PM, Nick Hall <nic...@ho...> wrote: > I have almost completed this work, just some final testing to do. > > Great... > I have a couple of questions. > > The classes Navigation and PersonNavigation were not doing anything > useful, so I commented out the code that used them. The purpose of > these classes seems to be to provide a most recently used list in the > "Go" menu. Was this functionality present in an old version of Gramps > or was it something that was never implemented? Are we considering > using this in the future? > Doing some SVN archaeology: http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/src/gui/viewmanager.py?view=log This look like old stuff. Before my time. > How do we want the signals to work with gramplets? At the moment the > 'active-changed' signal is connected to a method called > _active_changed. This displays a message in the status bar notifying > the user that the gramplet is running and then calls the active_changed > method. This is empty and can be over-ridden by the gramplet developer. > > I could provide 8 _<object>_active methods and 8 empty <object>_active > methods for the gramplet developer to override. These could be > automatically connected for all gramplets. The alternative would be to > provide a method such as: > > self.connect_signal('Media', self.my_method) > > to connect the signals to a method of the developers choice. Does > anyone have a preference? > > I'd prefer the string-constant (maybe "media", so this matches the case of config variables, and then you don't have to think about it), for the simple reason that since views are now plugins, I'd like to be able to put a View and matching gramplets together in a addon package. There should be nothing for core-gramps to worry about, as long as the gramplet and the view agree on the signals. Also, we don't need all of those methods, if we just know the view name. That saves some code in the methods, and makes it so we don't have to import something to get some other constants. But that's just my opinion. Thanks! -Doug > Either approach will be very easy now, and I should hopefully be > finished tomorrow. > > Regards, > > Nick. > > > ------------------------------------------------------------------------------ > This SF.Net email is sponsored by the Verizon Developer Community > Take advantage of Verizon's best-in-class app development support > A streamlined, 14 day to market process makes app distribution fast and > easy > Join now and get one step closer to millions of Verizon customers > http://p.sf.net/sfu/verizon-dev2dev > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |