From: Gerald B. <ger...@gm...> - 2009-09-23 11:08:18
|
Well the thing is since I like to test interactively without using the plugin manager I need to wrap those bits in try/except or I can't import my module into an interactive session (try it !). I'm just trying to work out a rational way to do it. On 9/22/09, Brian Matherly <br...@gr...> wrote: > Hi Gerald, > > I don't think anyone replied to your message. > >> Hi -- I've got a style question >> regarding plugins. First off, let me >> explain that I sometimes like to test my plugin libraries >> in an >> interactive Python session where the plugin manager is not >> available. >> That means that I need something like: >> >> try: >> from gettext import gettext as _ >> from gen.plug import PluginManager, Plugin >> except ImportError: >> print 'Plugin manager not imported.' >> >> somewhere in my module since my import may fail. >> Then, where I >> actually try to register my plugin, I have something like: >> >> try: >> >> PluginManager.get_instance().register_plugin( >> Plugin( >> name = __name__, >> description = _("My awesome >> plugin"), >> module_name = __name__ >> ) >> ) >> except NameError: >> print 'Plugin not registered.' >> >> Now to the style question: >> >> Following PEP8 and our own conventions, I would normally >> put the >> import at the top of the module, with other imports, and >> the call to >> the Plugin Manager at the bottom. However, I'm >> starting to think that >> it might be neater to keep these two things together at the >> bottom >> like this: >> >> #--------------------------------- >> # >> # register plugin >> # >> #--------------------------------- >> >> try: >> from gettext import gettext as _ >> from gen.plug import PluginManager, Plugin >> >> PluginManager.get_instance().register_plugin( >> Plugin( >> name = __name__, >> description = >> _("My awesome plugin"), >> module_name = >> __name__ >> ) >> ) >> except ImportError: >> print 'Plugin manager not imported.' >> >> Looking forward to learning what other devs think about >> this idea. > > I think your whole idea is crazy. I can't imagine what good would come of > it. If I ever saw a plugin in SVN with try/except statements placed in > seemingly random places, and imports not immediately at the top of the file, > I would probably take it upon myself to fix it. > > Sorry, I'm not much help. > > ~Brian > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > -- Sent from my mobile device Gerald Britton |